Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Change NoInteractive flag to NonInteractive #333

Open
jodybro opened this issue Jul 24, 2024 · 6 comments
Open

Feature: Change NoInteractive flag to NonInteractive #333

jodybro opened this issue Jul 24, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@jodybro
Copy link

jodybro commented Jul 24, 2024

Is your feature request related to a problem? Please describe.
No. Purely syntactical

Describe the solution you'd like
The flag to switch to non-interactive mode to be --non-interactive vs --nointeractive

Additional context
First off...I love this tool. It's able to fix things that other colleagues/friends can struggle with for hours in a matter of a few seconds.
I meant to make this request a while ago when I first found this tool but I completely forgot.

Basically the first time that I used it and wanted to delete resources noninteractively I typed --non-interactive off muscle memory vs the --no-interactive flag right now. I even checked the help output beforehand to make sure there was an automated process for resource deletion and everything but still used the former flag since most cli tools that can switch action modes standardize on that name.

@jodybro
Copy link
Author

jodybro commented Jul 24, 2024

Btw if yall want I can handle the refactor since it would be super simple

@yonahd yonahd added the enhancement New feature or request label Jul 25, 2024
@yonahd
Copy link
Owner

yonahd commented Jul 25, 2024

Hi
Happy you are finding kor useful! 🙂

We're open to this change but we would like to support the old version as well in this upcoming release and just print a deprecation notice on it.

If you would like to take this I'll assign it to you

@jodybro
Copy link
Author

jodybro commented Jul 31, 2024

@yonahd Yeah that sounds great! Do you have a version in mind to fully deprecate the flag? Or do you want a simple "This flag will be deprecated in favor of --non-interactive in a future release"?

@yonahd
Copy link
Owner

yonahd commented Jul 31, 2024

@jodybro v0.6.0

@jodybro
Copy link
Author

jodybro commented Jul 31, 2024

Gotcha @yonahd!

@yonahd
Copy link
Owner

yonahd commented Oct 18, 2024

@jodybro do you still want to handle this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants