From 1631e7953c4f64400b7e357b11c772af3836a17b Mon Sep 17 00:00:00 2001
From: Pranshu Aggarwal <70687348+Pranshu1902@users.noreply.github.com>
Date: Tue, 5 Sep 2023 20:07:13 +0530
Subject: [PATCH] remove extra loader and add success notification (#6210)

---
 src/Components/Users/SkillsSlideOver.tsx | 47 ++++++++++++------------
 1 file changed, 24 insertions(+), 23 deletions(-)

diff --git a/src/Components/Users/SkillsSlideOver.tsx b/src/Components/Users/SkillsSlideOver.tsx
index cf43b738181..343ea9062cc 100644
--- a/src/Components/Users/SkillsSlideOver.tsx
+++ b/src/Components/Users/SkillsSlideOver.tsx
@@ -55,6 +55,10 @@ export default ({ show, setShow, username }: IProps) => {
         Notification.Error({
           msg: "Error while adding skill",
         });
+      } else {
+        Notification.Success({
+          msg: "Skill added successfully",
+        });
       }
       setSelectedSkill(null);
       setIsLoading(false);
@@ -110,21 +114,19 @@ export default ({ show, setShow, username }: IProps) => {
       >
         <div>
           <div className="col-span-full sm:col-span-3 sm:col-start-2">
-            <div className="tooltip flex items-center gap-2">
-              <SkillSelect
-                multiple={false}
-                name="skill"
-                disabled={!authorizeForAddSkill}
-                showAll={true}
-                showNOptions={Infinity}
-                selected={selectedSkill}
-                setSelected={setSelectedSkill}
-                errors=""
-                username={username}
-              />
-              {isLoading ? (
-                <CircularProgress className="h-5 w-5" />
-              ) : (
+            {!isLoading && (
+              <div className="tooltip flex items-center gap-2">
+                <SkillSelect
+                  multiple={false}
+                  name="skill"
+                  disabled={!authorizeForAddSkill}
+                  showAll={true}
+                  showNOptions={Infinity}
+                  selected={selectedSkill}
+                  setSelected={setSelectedSkill}
+                  errors=""
+                  username={username}
+                />
                 <ButtonV2
                   disabled={!authorizeForAddSkill}
                   onClick={() => addSkill(username, selectedSkill)}
@@ -132,14 +134,13 @@ export default ({ show, setShow, username }: IProps) => {
                 >
                   {t("add")}
                 </ButtonV2>
-              )}
-              {!authorizeForAddSkill && (
-                <span className="tooltip-text tooltip-bottom -translate-x-24 translate-y-2">
-                  {t("contact_your_admin_to_add_skills")}
-                </span>
-              )}
-            </div>
-            {/* While loading skills, we display an additional circular progress to show we are fetching the information*/}
+                {!authorizeForAddSkill && (
+                  <span className="tooltip-text tooltip-bottom -translate-x-24 translate-y-2">
+                    {t("contact_your_admin_to_add_skills")}
+                  </span>
+                )}
+              </div>
+            )}
             {isLoading ? (
               <div className="mt-4 flex justify-center">
                 <CircularProgress />