Test PHP 7.4 on Travis (#16)

Author: yoanm

.travis.yml

@@ -4,6 +4,7 @@ php:
   - '7.1'
   - '7.2'
   - '7.3'
+  - '7.4'
 
 env:
   global:
@@ -25,7 +26,7 @@ before_install:
   - phpenv config-rm xdebug.ini || true
 
 install:
-  - composer require symfony/http-kernel:$SYMFONY_VERSION symfony/dependency-injection:$SYMFONY_VERSION
+  - composer require symfony/http-kernel:$SYMFONY_VERSION symfony/dependency-injection:$SYMFONY_VERSION symfony/routing:$SYMFONY_VERSION
   - make build
 script:
   - make test-technical

composer.json

@@ -33,7 +33,7 @@
     "php": ">=7.1",
     "yoanm/jsonrpc-server-sdk": "^3.0",
     "yoanm/symfony-jsonrpc-http-server": "^2.0",
-    "yoanm/jsonrpc-params-symfony-validator-sdk": "^0.1",
+    "yoanm/jsonrpc-params-symfony-validator-sdk": "^0.2",
     "symfony/http-kernel": "^3.0 || ^4.0",
     "symfony/dependency-injection": "^3.0 || ^4.0"
   },
@@ -42,7 +42,7 @@
     "behat/behat": "~3.0",
     "squizlabs/php_codesniffer": "3.*",
     "phpunit/phpunit": "^7.0 || ^8.0",
-    "matthiasnoback/symfony-dependency-injection-test": "^2.0 || ^3.0",
+    "matthiasnoback/symfony-dependency-injection-test": "^3.0 || ^4.0",
     "matthiasnoback/symfony-config-test": "^3.0 || ^4.0",
     "symfony/framework-bundle": "^3.0 || ^4.0",
     "symfony/routing": "^3.0 || ^4.0",

tests/Common/DependencyInjection/AbstractTestClass.php

@@ -15,14 +15,14 @@ abstract class AbstractTestClass extends AbstractExtensionTestCase
     /**
      * {@inheritdoc}
      */
-    protected function getContainerExtensions()
+    protected function getContainerExtensions(): array
     {
         return [
             new JsonRpcParamsValidatorExtension()
         ];
     }
 
-    protected function load(array $configurationValues = [], $mockSfValidator = true)
+    protected function loadContainer(array $configurationValues = [], $mockSfValidator = true): void
     {
         if (true === $mockSfValidator) {
             $sfValidatorDefinition = new Definition(ValidatorInterface::class);

tests/Functional/DependencyInjection/ConfigFilesTest.php

@@ -14,7 +14,7 @@ class ConfigFilesTest extends AbstractTestClass
     /**
      * {@inheritdoc}
      */
-    protected function getContainerExtensions()
+    protected function getContainerExtensions(): array
     {
         return [
             new JsonRpcParamsValidatorExtension()
@@ -31,7 +31,7 @@ protected function getContainerExtensions()
      */
     public function testShouldHaveService($serviceId, $expectedClassName, $public)
     {
-        $this->load([]);
+        $this->loadContainer([]);
 
         $this->assertContainerBuilderHasService($serviceId, $expectedClassName);
         if (true === $public) {

tests/Functional/DependencyInjection/JsonRpcHttpServerExtensionTest.php

@@ -12,7 +12,7 @@ class JsonRpcHttpServerExtensionTest extends AbstractTestClass
     /**
      * {@inheritdoc}
      */
-    protected function getContainerExtensions()
+    protected function getContainerExtensions(): array
     {
         return [
             new JsonRpcParamsValidatorExtension()
@@ -22,7 +22,7 @@ protected function getContainerExtensions()
 
     public function testShouldBeLoadable()
     {
-        $this->load();
+        $this->loadContainer();
 
         $this->assertValidatorIsUsable();
     }