Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hub_token not implemented #15

Open
DCNemesis opened this issue Feb 28, 2024 · 5 comments · May be fixed by #16
Open

hub_token not implemented #15

DCNemesis opened this issue Feb 28, 2024 · 5 comments · May be fixed by #16

Comments

@DCNemesis
Copy link

The help documentation suggests hub_token can be used to push model to the hub in training, but it is not used in the code. As a result, the model fails to push during training to a private repo (without giving any error messages).
@ylacombe
Copy link
Owner

Hi @DCNemesis, thanks for opening the issue, would you like to open a PR to fix this ?
If this is time-sensitive, I can take a look today or tomorrow if you want

@DCNemesis
Copy link
Author

I've been focusing more on finding the right parameters for training a multi-speaker model in a new language, figuring I can always upload the checkpoint when it finishes/works. But, I'll take a look and see if I can get it working on a smaller test.

@ylacombe
Copy link
Owner

Let me know how it goes!

@DCNemesis DCNemesis linked a pull request Feb 29, 2024 that will close this issue
Open
@DCNemesis
Copy link
Author

The test worked fine. It doesn't upload checkpoints or training data, but it uploads the model at the end.

@ylacombe
Copy link
Owner

ylacombe commented Mar 5, 2024

Thanks for the quick PR, will test on my side and merge when ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add token and privacy settings for pushes to hub DCNemesis/finetune-hf-vits
2 participants
@DCNemesis @ylacombe