Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the person name gets printed when pressing backspace on someone's cursor on mobile #174

Open
1 task
kemo-1 opened this issue Dec 20, 2024 · 3 comments
Open
1 task
Assignees
Labels
bug Something isn't working

Comments

@kemo-1
Copy link

kemo-1 commented Dec 20, 2024

Describe the bug
when pressing backspace on someone's cursor their name gets printed into the text document

To Reproduce
Steps to reproduce the behavior:

  1. visit https://tiptap.dev/docs/editor/extensions/functionality/collaboration-cursor
  2. open the website in 2 tabs
  3. try to delete someones cursor by pressing backspace where the cursor of the other person is on an empty line
  4. try to do the same thing using edge on mobile latest version or chrome beta on mobile latest version at the time of writting

the issue dosen't happen on pc versions or when using a pc version bundled into a mobile app (for example kiwi browser which is a desktop chromium but bundled to be on mobile)

the issue is related to chromium version for android tested on andriod v10

Expected behavior
the same behavior as desktop version when trying to delete someone cursor on an empty line it should delete the line and push both cursors one line up

Screenshots
( i will add in comments )

Environment Information

  • chromium on andriod

[email protected]
[email protected] deduped

Additional context
Add any other context about the problem here.

  • This issue isn't a blocker for my project but I wanted to let the devs know about it... and it might be a small fix with css or html and its nice to have less bugs in general
@kemo-1 kemo-1 added the bug Something isn't working label Dec 20, 2024
@kemo-1
Copy link
Author

kemo-1 commented Dec 20, 2024

SVID_20241220_152238_1.mp4

on microsoft edge latest ^^ and the same issue om chrome beta

the issue doesn't exist when using desktop versions even the ones bundled to andriod like kiwi browser

@dmonad
Copy link
Member

dmonad commented Dec 20, 2024

This is weird.

y-prosemirror renders the username using ProseMirror's Decoration.widget. I create a DOM element and feed it into the widget. I'm not doing anything edgy here..

There seems to be a recent change in WebKit that affects ProseMirror's ability to read changes. @marijnh do you have an idea what's going on?

@kemo-1
Copy link
Author

kemo-1 commented Dec 20, 2024

someone said its an andriod issue so this is kiwi browser (they take chromium for desktop and bundle it somehow for andriod so you can use chrome extensions etc)

SVID_20241221_003307_1.mp4

i feel like the issue is the browser thinks the username is part of the text document so it trys to delete the space or the first char of the name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants