Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I undo some content across lines, the enabled state of the tool gets lost. #139

Open
2 tasks done
shlroland opened this issue Jul 20, 2023 · 0 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@shlroland
Copy link

shlroland commented Jul 20, 2023

Checklist

Describe the bug
When I undo some content across lines, the enabled state of the tool gets lost.

To Reproduce
Steps to reproduce the behavior:

  1. can use the official example https://docs.yjs.dev/ecosystem/editor-bindings/prosemirror
  2. write something and ctrl-z
  3. some tool buttons are disabled

Expected behavior
tool buttons are still enabled

Screenshots

Kapture.2023-07-20.at.20.13.22.mp4

Environment Information

  • Browser / Node.js [e.g. Chrome, Firefox, Node.js]
  • Yjs version and the versions of the y-* modules you are using [e.g. yjs v13.0.1, y-webrtc v1.2.1]. Use npm ls yjs to find out the exact version you are using.

Additional context
Add any other context about the problem here.

@shlroland shlroland added the bug Something isn't working label Jul 20, 2023
romansp added a commit to Axure-Software/y-prosemirror that referenced this issue Oct 18, 2023
- introduce RecoverableSelection that wraps current selection and allows it to be restored later
- get ySyncPlugin state inside undoManager event hooks

fixes yjs#43, yjs#101, yjs#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants