From a0ff0b30f85f335eba7760f5501cfa123fb6e9d9 Mon Sep 17 00:00:00 2001
From: Efertone <efertone@pm.me>
Date: Wed, 4 Oct 2023 21:22:59 +0200
Subject: [PATCH] fix: bash autocomplete

The bash autocomplete had a bug, most likely as a result of a lazy `:% s/PROG/totp-cli/g`.

I added extra docs about autocomplete.

Fixes #93

References:
* https://github.com/yitsushi/totp-cli/issues/93

Signed-off-by: Efertone <efertone@pm.me>
---
 README.md                      | 15 +++++++++++++++
 autocomplete/bash_autocomplete |  3 ---
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 0dfedcf..ee8294f 100644
--- a/README.md
+++ b/README.md
@@ -258,9 +258,16 @@ totp-cli import list.yaml
 
 ### Shell Completion
 
+Disclaimer: I don't have much expertise with auto-complete integrations. The
+following instructions should be enough, but it is possible they are not. Feel
+free to open a Pull Request with any additional suggestions/fixes either in the
+docs or the autocomplete scripts.
+
 * Bash: `autocomplete/bash_autocomplete`
 * Zsh: `autocomplete/zsh_autocomplete`
 
+#### Zsh
+
 A function to provide tab-completion for zsh is in the file
 `autocomplete/zsh_autocomplete`. When installing or packaging totp-cli this
 should preferably be installed in `$prefix/share/zsh/site-functions`. Otherwise,
@@ -270,11 +277,19 @@ functions into the folder `~/.zsh/completions` you must add the following to
 your zsh main config file (`.zshrc`):
 
 ```shell
+cp autocomplete/zsh_autocomplete ~/.zsh/functions/_totp_cli
 fpath=( ~/.zsh/completions $fpath )
 autoload -U compinit
 compinit
 ```
 
+#### Bash
+
+```
+mkdir -p ~/.local/share/bash-completion/completions
+cp autocomplete/bash_autocomplete ~/.local/share/bash-completion/completions/totp-cli
+```
+
 ## About the password
 
 The password should never be passed directly to any applications to unlock it.
diff --git a/autocomplete/bash_autocomplete b/autocomplete/bash_autocomplete
index 9d112b5..fee91f0 100644
--- a/autocomplete/bash_autocomplete
+++ b/autocomplete/bash_autocomplete
@@ -1,7 +1,5 @@
 #! /bin/bash
 
-: totp-cli
-
 # Macs have bash3 for which the bash-completion package doesn't include
 # _init_completion. This is a minimal version of that function.
 _cli_init_completion() {
@@ -32,4 +30,3 @@ _cli_bash_autocomplete() {
 }
 
 complete -o bashdefault -o default -o nospace -F _cli_bash_autocomplete totp-cli
-unset totp-cli