Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the request struct does not respect optional fields #95

Open
yitsushi opened this issue Apr 17, 2022 · 0 comments
Open

Some of the request struct does not respect optional fields #95

yitsushi opened this issue Apr 17, 2022 · 0 comments
Labels
🐛 Bug Something isn't working ❤️ Good first issue Good for newcomers

Comments

@yitsushi
Copy link
Owner

Describe the bug
Some of the requests have missing omitempty annotations, because of that, the request will contain the field with default value (empty string or 0) and Misskey will handle them as requested value and not as an optional field.

🙂 Expected behavior
All request structs have proper JSON annotation.

☹️ Actual Behavior
Some of the request structs have improper JSON annotation.

📌 Additional context
Reference: #93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working ❤️ Good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yitsushi