diff --git a/CHANGELOG.md b/CHANGELOG.md index 036cdd37..b51f81ce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,7 +40,7 @@ - New #355: Use `DateTimeColumn` class for datetime column types (@Tigrov) - New #356, #357: Implement `DMLQueryBuilder::upsertReturning()` method (@Tigrov) - Enh #356, #357: Refactor `Command::insertWithReturningPks()` and `DMLQueryBuilder::upsert()` methods (@Tigrov) -- Enh #360: Implement `DMLQueryBuilder::insertWithReturningPks()` method (@Tigrov) +- Enh #360, #361: Implement `DMLQueryBuilder::insertReturningPks()` method (@Tigrov) - Chg #362: Replace column and table name quote character from ` to " (@Tigrov) ## 1.2.0 March 21, 2024 diff --git a/src/DMLQueryBuilder.php b/src/DMLQueryBuilder.php index c8e4da8e..34e36e36 100644 --- a/src/DMLQueryBuilder.php +++ b/src/DMLQueryBuilder.php @@ -17,7 +17,7 @@ */ final class DMLQueryBuilder extends AbstractDMLQueryBuilder { - public function insertWithReturningPks(string $table, array|QueryInterface $columns, array &$params = []): string + public function insertReturningPks(string $table, array|QueryInterface $columns, array &$params = []): string { $insertSql = $this->insert($table, $columns, $params); $tableSchema = $this->schema->getTableSchema($table); diff --git a/tests/Provider/QueryBuilderProvider.php b/tests/Provider/QueryBuilderProvider.php index c231b2fe..6909d723 100644 --- a/tests/Provider/QueryBuilderProvider.php +++ b/tests/Provider/QueryBuilderProvider.php @@ -112,7 +112,7 @@ public static function insert(): array return $insert; } - public static function insertWithReturningPks(): array + public static function insertReturningPks(): array { return [ 'regular-values' => [ diff --git a/tests/QueryBuilderTest.php b/tests/QueryBuilderTest.php index d0f3c22a..a1d9f027 100644 --- a/tests/QueryBuilderTest.php +++ b/tests/QueryBuilderTest.php @@ -509,15 +509,15 @@ public function testInsert( parent::testInsert($table, $columns, $params, $expectedSQL, $expectedParams); } - #[DataProviderExternal(QueryBuilderProvider::class, 'insertWithReturningPks')] - public function testInsertWithReturningPks( + #[DataProviderExternal(QueryBuilderProvider::class, 'insertReturningPks')] + public function testInsertReturningPks( string $table, array|QueryInterface $columns, array $params, string $expectedSQL, array $expectedParams ): void { - parent::testInsertWithReturningPks($table, $columns, $params, $expectedSQL, $expectedParams); + parent::testInsertReturningPks($table, $columns, $params, $expectedSQL, $expectedParams); } public function testRenameColumn(): void