Update tests according changes in db (#369)

Author: Tigrov

tests/ColumnTest.php

@@ -9,20 +9,20 @@
 use PDO;
 use PHPUnit\Framework\Attributes\DataProviderExternal;
 use Yiisoft\Db\Command\Param;
+use Yiisoft\Db\Connection\ConnectionInterface;
 use Yiisoft\Db\Expression\Expression;
 use Yiisoft\Db\Mssql\Column\BinaryColumn;
 use Yiisoft\Db\Mssql\Column\ColumnBuilder;
-use Yiisoft\Db\Mssql\Connection;
 use Yiisoft\Db\Mssql\Tests\Provider\ColumnProvider;
 use Yiisoft\Db\Mssql\Tests\Support\TestTrait;
-use Yiisoft\Db\Query\Query;
 use Yiisoft\Db\Schema\Column\BooleanColumn;
 use Yiisoft\Db\Schema\Column\ColumnInterface;
 use Yiisoft\Db\Schema\Column\DoubleColumn;
 use Yiisoft\Db\Schema\Column\IntegerColumn;
 use Yiisoft\Db\Schema\Column\StringColumn;
 use Yiisoft\Db\Tests\Common\CommonColumnTest;
 
+use function iterator_to_array;
 use function str_repeat;
 
 /**
@@ -34,7 +34,7 @@ final class ColumnTest extends CommonColumnTest
 
     protected const COLUMN_BUILDER = ColumnBuilder::class;
 
-    private function insertTypeValues(Connection $db): void
+    protected function insertTypeValues(ConnectionInterface $db): void
     {
         $db->createCommand()->insert(
             'type',
@@ -51,7 +51,7 @@ private function insertTypeValues(Connection $db): void
         )->execute();
     }
 
-    private function assertTypecastedValues(array $result, bool $allTypecasted = false): void
+    protected function assertTypecastedValues(array $result, bool $allTypecasted = false): void
     {
         $this->assertSame(1, $result['int_col']);
         $this->assertSame(str_repeat('x', 100), $result['char_col']);
@@ -68,44 +68,6 @@ private function assertTypecastedValues(array $result, bool $allTypecasted = fal
         }
     }
 
-    public function testQueryWithTypecasting(): void
-    {
-        $db = $this->getConnection(true);
-
-        $this->insertTypeValues($db);
-
-        $query = (new Query($db))->from('type')->withTypecasting();
-
-        $result = $query->one();
-
-        $this->assertTypecastedValues($result);
-
-        $result = $query->all();
-
-        $this->assertTypecastedValues($result[0]);
-
-        $db->close();
-    }
-
-    public function testCommandWithPhpTypecasting(): void
-    {
-        $db = $this->getConnection(true);
-
-        $this->insertTypeValues($db);
-
-        $command = $db->createCommand('SELECT * FROM type')->withPhpTypecasting();
-
-        $result = $command->queryOne();
-
-        $this->assertTypecastedValues($result);
-
-        $result = $command->queryAll();
-
-        $this->assertTypecastedValues($result[0]);
-
-        $db->close();
-    }
-
     public function testSelectWithPhpTypecasting(): void
     {
         $db = $this->getConnection();
@@ -131,6 +93,12 @@ public function testSelectWithPhpTypecasting(): void
 
         $this->assertSame([$expected], $result);
 
+        $result = $db->createCommand($sql)
+            ->withPhpTypecasting()
+            ->query();
+
+        $this->assertSame([$expected], iterator_to_array($result));
+
         $result = $db->createCommand('SELECT 2.5')
             ->withPhpTypecasting()
             ->queryScalar();
@@ -146,27 +114,6 @@ public function testSelectWithPhpTypecasting(): void
         $db->close();
     }
 
-    public function testPhpTypeCast(): void
-    {
-        $db = $this->getConnection(true);
-        $schema = $db->getSchema();
-        $columns = $schema->getTableSchema('type')->getColumns();
-
-        $this->insertTypeValues($db);
-
-        $query = (new Query($db))->from('type')->one();
-
-        $result = [];
-
-        foreach ($columns as $columnName => $column) {
-            $result[$columnName] = $column->phpTypecast($query[$columnName]);
-        }
-
-        $this->assertTypecastedValues($result, true);
-
-        $db->close();
-    }
-
     public function testColumnInstance()
     {
         $db = $this->getConnection(true);