Add alias in DQLQueryBuilder::selectExists() method for consistency (#363)

Author: Tigrov

CHANGELOG.md

@@ -43,6 +43,7 @@
 - New #358: Use `DateTimeColumn` class for datetime column types (@Tigrov)
 - New #361: Implement `DMLQueryBuilder::upsertWithReturningPks()` method (@Tigrov)
 - Enh #361: Refactor `DMLQueryBuilder::insertWithReturningPks()` method (@Tigrov)
+- Chg #363: Add alias in `DQLQueryBuilder::selectExists()` method for consistency with other DBMS (@Tigrov)
 
 ## 1.2.0 March 21, 2024
 

src/DQLQueryBuilder.php

@@ -39,7 +39,7 @@ public function buildOrderByAndLimit(
 
     public function selectExists(string $rawSql): string
     {
-        return 'SELECT CASE WHEN EXISTS(' . $rawSql . ') THEN 1 ELSE 0 END';
+        return 'SELECT CASE WHEN EXISTS(' . $rawSql . ') THEN 1 ELSE 0 END AS [0]';
     }
 
     protected function defaultExpressionBuilders(): array

tests/Provider/QueryBuilderProvider.php

@@ -395,17 +395,6 @@ public static function insertWithReturningPks(): array
         ];
     }
 
-    public static function selectExist(): array
-    {
-        $selectExist = parent::selectExist();
-
-        $selectExist[0][1] = <<<SQL
-        SELECT CASE WHEN EXISTS(SELECT 1 FROM `table` WHERE `id` = 1) THEN 1 ELSE 0 END
-        SQL;
-
-        return $selectExist;
-    }
-
     public static function upsert(): array
     {
         $concreteData = [

tests/QueryBuilderTest.php

@@ -413,10 +413,16 @@ public function testResetSequence(): void
         );
     }
 
-    #[DataProviderExternal(QueryBuilderProvider::class, 'selectExist')]
-    public function testSelectExists(string $sql, string $expected): void
+    public function testSelectExists(): void
     {
-        parent::testSelectExists($sql, $expected);
+        $db = $this->getConnection();
+        $qb = $db->getQueryBuilder();
+
+        $sql = 'SELECT 1 FROM [customer] WHERE [id] = 1';
+        // Alias is not required in MSSQL, but it is added for consistency with other DBMS.
+        $expected = 'SELECT CASE WHEN EXISTS(SELECT 1 FROM [customer] WHERE [id] = 1) THEN 1 ELSE 0 END AS [0]';
+
+        $this->assertSame($expected, $qb->selectExists($sql));
     }
 
     #[DataProviderExternal(QueryBuilderProvider::class, 'update')]