LARGE_INTEGER (windows 7,8 not supported?)

[UnrealKaraulov]

[UnrealKaraulov]

httplib.h(2862): error C2228: left of '.HighPart' must have class/struct/union 

[UnrealKaraulov]

Also I has randomly strange warnings

D:\a\testProjectWin7\testProjectWin7\testProjectWin7\src\httplib.h(2832): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\testProjectWin7\testProjectWin7\testProjectWin7\testProjectWin7.vcxproj]
D:\a\testProjectWin7\testProjectWin7\testProjectWin7\src\httplib.h(2844): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\testProjectWin7\testProjectWin7\testProjectWin7\testProjectWin7.vcxproj]
D:\a\testProjectWin7\testProjectWin7\testProjectWin7\src\httplib.h(2854): warning C4293: '<<': shift count negative or too big, undefined behavior [D:\a\testProjectWin7\testProjectWin7\testProjectWin7\testProjectWin7.vcxproj]
D:\a\testProjectWin7\testProjectWin7\testProjectWin7\src\httplib.h(2857): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\testProjectWin7\testProjectWin7\testProjectWin7\testProjectWin7.vcxproj]
D:\a\testProjectWin7\testProjectWin7\testProjectWin7\src\httplib.h(2871): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\testProjectWin7\testProjectWin7\testProjectWin7\testProjectWin7.vcxproj]
                     

[UnrealKaraulov]

If Microsoft stopped support Windows XP, 7, 8, 9, that doesn't mean that users don't use these versions of the OS!

Users still use Windows 7,8 massive, even WinXP 🤣 sometimes))

[UnrealKaraulov]

Possible just invalid #if...#else order in this commit c8bcaf8

[yhirose]

@UnrealKaraulov please keep in mind that cpp-httplib doesn't officially support Windows 8 or lower.
https://github.com/yhirose/cpp-httplib?tab=readme-ov-file#windows

@mol123, @sergio-nsk, do you have any thoughts on this?

[UnrealKaraulov]

Possible need something like : (not 100% sure)

After this fix, i now can compile httplib for Windows 7+ and even for Windows XP+.

[UnrealKaraulov]

@UnrealKaraulov please keep in mind that cpp-httplib doesn't officially support Windows 8 or lower. https://github.com/yhirose/cpp-httplib?tab=readme-ov-file#windows

@mol123, @sergio-nsk, do you have any thoughts on this?

But why? Then users can stop support cpp-httplib in own projects...

[mol123]

@UnrealKaraulov, can you please confirm that you're using the right preprocessor flags (see here: #1869 (comment)) when compiling your code?

[UnrealKaraulov]

@UnrealKaraulov, can you please confirm that you're using the right preprocessor flags (see here: #1869 (comment)) when compiling your code?

Yes,

Looks like 'size' variable passed in not same case as CreateFileMappingW sometimes. (Not same #if...#else checks)

[mol123]

@UnrealKaraulov, would you mind testing, if the following change fixes the issue?

Replace this line:

  hMapping_ = ::CreateFileMappingW(hFile_, NULL, PAGE_READONLY, size.HighPart,
                                   size.LowPart, NULL);

With the following line:

  hMapping_ = ::CreateFileMappingW(hFile_, NULL, PAGE_READONLY,
    static_cast<DWORD>((size_ >> 32) & 0xFFFFFFFF),
    static_cast<DWORD>(size_ & 0xFFFFFFFF), NULL);

[sergio-nsk]

If Microsoft stopped support Windows XP, 7, 8, 9, that doesn't mean that users don't use these versions of the OS!

Users still use Windows 7,8 massive, even WinXP 🤣 sometimes))

Obviously such users can use older cpp-httplib releases. They got used that if they use older and unsupported Windows, they can not use the newest software.

[sergio-nsk]

@mol123, @sergio-nsk, do you have any thoughts on this?

Windows 7 users can use older cpp-httplib releases.

I don't get why cpp-httplib vendors spend so much efforts on Windows 7 that is explicitly mentioned as not supported in README.md.

Also I would not spend time on users that post text in pictures until they post them as text.

[UnrealKaraulov]

@UnrealKaraulov, would you mind testing, if the following change fixes the issue?

Replace this line:

  hMapping_ = ::CreateFileMappingW(hFile_, NULL, PAGE_READONLY, size.HighPart,
                                   size.LowPart, NULL);

With the following line:

  hMapping_ = ::CreateFileMappingW(hFile_, NULL, PAGE_READONLY,
    static_cast<DWORD>((size_ >> 32) & 0xFFFFFFFF),
    static_cast<DWORD>(size_ & 0xFFFFFFFF), NULL);

Yes

I think the problem is that LARGE_INTEGER size does not always get passed to the CreateFileMappingW function because the #if...#else checks differ.
There is a high probability that LARGE_INTEGER size will not exist, and something other than the size variable is passed to CreateFileMappingW.
GetFileSizeEx is available even in WinXP+, so maybe we can simply cut out the case of using GetFileSize?

GetFileSizeEx: