Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python for Algorithm Trading - Chapter 5 - Page 158 - Typo #3

Open
edgetrader opened this issue May 5, 2021 · 1 comment
Open

Python for Algorithm Trading - Chapter 5 - Page 158 - Typo #3

edgetrader opened this issue May 5, 2021 · 1 comment

Comments

@edgetrader
Copy link

edgetrader commented May 5, 2021

For recording purpose here

Code line 162

%%time
model.fit(training_data[cols], 
          training_data['direction'], 
          epochs=50, verbose=False, 
          validation_split=0.2, shuffle=False)

Should be to train model with normalised features

%%time
model.fit(training_data_[cols], 
          training_data['direction'], 
          epochs=50, verbose=False, 
          validation_split=0.2, shuffle=False)

Dr Yves' has replied here

@BeneInfosec
Copy link

For recording purpose here

Code line 162

%%time
model.fit(training_data[cols], 
          training_data['direction'], 
          epochs=50, verbose=False, 
          validation_split=0.2, shuffle=False)

Should be to train model with normalised features

%%time
model.fit(training_data_[cols], 
          training_data['direction'], 
          epochs=50, verbose=False, 
          validation_split=0.2, shuffle=False)

Dr Yves' has replied here

Yes, I think the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants