Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Configure which Alerts to be rejected #1642

Closed
daso94msg opened this issue Aug 19, 2024 · 4 comments
Closed

Feature Request: Configure which Alerts to be rejected #1642

daso94msg opened this issue Aug 19, 2024 · 4 comments
Labels
feature request 💬 Requests for new features

Comments

@daso94msg
Copy link

Missing functionality

Right now it is possible to switch on/off the rejection of variables entirely with the configuration-variable reject_variables.

Proposed feature

I would like to be able to only reject some type of variable. For example reject missing variables, but still show constant variables normally in the report.

Alternatives considered

I'm not sure about a workaround, to me it seems like it depends on the Typeset as they all come back to the unsupported Basetype-

Additional context

No response

@fabclmnt
Copy link
Contributor

Hi @daso94msg ,

thank you for your feature request. Nevertheless it is not totally clear what is the end goal and utility of the request.

Can you please provide a practical example?

@fabclmnt fabclmnt added the feature request 💬 Requests for new features label Aug 26, 2024
@daso94msg
Copy link
Author

We use the reports to have a first glance at unknown data sets.
A column that consists only of NA-values is indeed not that interesting.
For a constant column on the other hand, it could still be interessting to check if that constant value is plausible.
But eventually they both get grayed out in the report as rejected, which tempts you to not look into them at all.

If it's not a feature worth pursuing for you, could you give me an idea where I have to look into it?
Where does the rejection happen? I already looked in the ./ydata_profiling/model/alerts.py and ./model/pandas/summary_pandas.py where I found out it depends on the description["type"] of a series_description being "Unsupported" or not.

@fabclmnt
Copy link
Contributor

fabclmnt commented Oct 15, 2024

@daso94msg , I'm sorry but I'm sure if I followed the request.
Constant columns in Ydata-profiling are not returned as rejected columns. They are in fact returned with a "Constant" warning as they remain the same value across the rows.

Can you please provide a visual example with a dataset? That way we will be able to better understand the request and let you know of this is aligned with something that we would pursue.

@daso94msg
Copy link
Author

Hi @fabclmnt,

thanks for coming back at me.
Unfortunately I can't reproduce the issue as I do not have access to the exact data that created the report in the first place, but I still have a screenshot of it:

image

But I think it's not really possible to solve the problem then.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 💬 Requests for new features
Projects
None yet
Development

No branches or pull requests

3 participants