Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @headlessui/react version 2 #115

Closed
PodStuart opened this issue May 24, 2024 · 4 comments
Closed

Support for @headlessui/react version 2 #115

PodStuart opened this issue May 24, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@PodStuart
Copy link

Is your feature request related to a problem? Please describe.
Unable to upgrade to @headlessui/react version 2.

Describe the solution you'd like
Support for @headlessui/react version 2.

Describe alternatives you've considered
Dropping use of @headlessui-float/react.

@PodStuart PodStuart added the enhancement New feature or request label May 24, 2024
@ycs77
Copy link
Owner

ycs77 commented May 25, 2024

Hi @PodStuart. Sorry, I can not support the @headlessui/react v2.

Because the @headlessui/react v2 includes the Floating UI, conflict arises in this package, which cannot function normally.

So, I suggest you abandon this package, upgrade to @headlessui/react v2 to use the anchor prop instead of this package, and reference the example to using the transition for menu or other components.

@ycs77 ycs77 closed this as completed May 25, 2024
@ycs77 ycs77 closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2024
@ycs77 ycs77 pinned this issue May 28, 2024
@ycs77 ycs77 unpinned this issue May 28, 2024
@razzeee
Copy link

razzeee commented Jun 11, 2024

But you can't do autoplacement with the anchor prop?

I've also migrated some of our projects and they all seem to run fine, as far as I can tell.

@ycs77
Copy link
Owner

ycs77 commented Jun 13, 2024

@razzeee

But you can't do autoplacement with the anchor prop?

Although I can do auto-placement, but the anchor prop of Headless UI v2 only implements the auto-placement feature, so I can't support the other features of this package.

The usage of Floating UI APIs with this package and Headless UI v2 is different, I am unable to implement full feature support (like Floating UI options, arrow, portal...) for Headless UI v2, and this package is non-invasive to the Headless UI, if the Headless UI has changed and this package will be affected a lot. So I give up support it. 😅

I've also migrated some of our projects and they all seem to run fine, as far as I can tell.

If you run fine, continue to do it!

@scottwillman
Copy link

Well @ycs77 - Let me just say thank you for supporting it while you could!! Much love. It's been a big help to me at missn.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants