You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, thanks for this extension! Just a minor thing: I noticed this extension will be activated whenever VSC starts up.
As the API reference states:
To ensure a great user experience, please use this activation event in your extension only when no other activation events combination works in your use-case.
There are some other similar extensions that use a more specific activation event to activate only when needed (e.g. when a surround command is triggered).
The text was updated successfully, but these errors were encountered:
Hey @femto-code. Thank you very much for the feedback. Yes, you are totally right and I'm aware of that. When I released the extension, activation events were causing the extension to start with a slight lag. I wanted to avoid that back then.
I totally agree that it's the best practice but since the activation function is only triggered once, and the extension is very lightweight I don't think it's a very big problem at the moment.
I'll look into this and if it's fine, I'll change that.
Cheers,
amac4015
added a commit
to amac4015/vscode-surround
that referenced
this issue
Jan 6, 2023
First, thanks for this extension! Just a minor thing: I noticed this extension will be activated whenever VSC starts up.
As the API reference states:
There are some other similar extensions that use a more specific activation event to activate only when needed (e.g. when a surround command is triggered).
The text was updated successfully, but these errors were encountered: