IAX fixes #6
Open
IAX fixes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in Asterisk IAX2 in asterisk/asterisk@3072c54
yiax wrongly assumed that the ENCRYPTION IE is a single byte, while in reality it is 16bit / 2 bytes. It has been two bytes ever since it was introduced in Asterisk in 2004. This misunderstanding probably arose from RFC5456 which erroneosly states that the length of this IE is 0x01 while its body is 2 bytes long (See Section 8.6.34 at https://datatracker.ietf.org/doc/html/rfc5456)
|
Dear yate team, it has been multiple months without any feedback here. Do you have any change requests? We're more than haappy to adjust our patches if you have any. This PR contains valid bug-fixes for interoperability with modern Asterisk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we started to interoperate our yate installation with the world-wide community of analog phone collectors (C*NET / ckts.info), two IAX interoperability problems with their Asterisk boxes became apparrent. Let's fix them