[Bug?]: Setting `script-shell=pwsh` breaks yarn preinstall when it is a dependency

[mhnsn]

Self-service

• I'd be willing to implement a fix

Describe the bug

If you explicitly have script-shell=pwsh in .npmrc , the yarn preinstall script fails if yarn is a dependency of another project. The generated syntax is pwsh -c :; (node ./preinstall.js > /dev/null 2>&1 || true), which isn't valid PowerShell syntax. This blocks the module from ever finishing installation.

To reproduce

• npm config set script-shell pwsh
• npm i -g oclif
• oclif generate <my-cli>
• cd my-cli
• npm i

Yarn appears to be a dependency of https://github.com/oclif/plugin-plugins, which is then depended on by https://github.com/oclif/oclif.

The issue can be resolved by removing the offending line in .npmrc, but that doesn't really solve the underlying problem, which is that yarn is generating invalid syntax for the environment it's running in.

Environment

System:
    OS: Windows 10 10.0.19042
    CPU: (8) x64 Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz
  Binaries:
    Node: 14.16.0 - ~\AppData\Local\Temp\xfs-c51972fb\node.CMD
    Yarn: 1.22.15 - ~\AppData\Local\Temp\xfs-c51972fb\yarn.CMD
    npm: 8.3.2 - C:\Program Files\nodejs\npm.CMD

Additional context

The relevant yarn dependency entry from oclif/plugin-plugins "^1.22.17", which is properly downloaded. The script appears to run against the higher version, which generates the issue.

[yarnbot]

Hi! 👋

This issue looks stale, and doesn't feature the reproducible label - which implies that you didn't provide a working reproduction using Sherlock. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it or you edit your first post to include a formal reproduction (you can use the playground for that).

Note that we require Sherlock reproductions for long-lived issues (rather than standalone git repositories or similar) because we're a small team. Sherlock gives us the ability to check which bugs are still affecting the master branch at any given point, and decreases the amount of code we need to run on our own machines (thus leading to faster bug resolutions). It helps us help you! 😃

If you absolutely cannot reproduce a bug on Sherlock (for example because it's a Windows-only issue), a maintainer will have to manually add the upholded label. Thanks for helping us triaging our repository! 🌟

[mhnsn]

Sherlock does not appear to expose the necessary CLI access to reproduce this issue.