Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake spectrometer does not properly update mapping id #31

Open
ksunden opened this issue Sep 21, 2022 · 1 comment
Open

fake spectrometer does not properly update mapping id #31

ksunden opened this issue Sep 21, 2022 · 1 comment

Comments

@ksunden
Copy link
Member

ksunden commented Sep 21, 2022

self._mappings["wavelengths"] = self._gen_mapping()

Since we use set_item here, the mapping id does not get updated by the mix-in class, which requires that you do specifically self._mappings = new_mapping.

I expect this may be a common error, perhaps we should look into solutions to make the version that at least rewrites the top level of entries automatically properly increment mapping_id.

@ksunden
Copy link
Member Author

ksunden commented Sep 21, 2022

Additionally, the mapping is not computed until a measurement is taken, so if you ask for mapping first it will be outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant