Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.4] Additional axes with NBT data in config #50

Open
Terpo opened this issue Jan 1, 2021 · 0 comments
Open

[1.16.4] Additional axes with NBT data in config #50

Terpo opened this issue Jan 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Terpo
Copy link

Terpo commented Jan 1, 2021

Is your feature request related to a problem? Please describe.
It is already possible to add additional axes to the tag "ages_api:axes" but as far as I know it is not possible to use NBT data in tags.
Example trying to add tetra axes in CraftTweaker:

var axes = <tag:ages_api:axes>;
var tetraAxe = <item:tetra:modular_double>.withTag({
	"double/head_left": "double/basic_axe_left" as string, 
	"double/head_right": "double/butt_right" as string
});
var tetraDoubleAxe = <item:tetra:modular_double>.withTag({
	"double/head_left": "double/basic_axe_left" as string, 
	"double/head_right": "double/basic_axe_right" as string
});

axes.addItems(tetraAxe);
axes.addItems(tetraDoubleAxe);

As tags do not support NBT, it only adds "tetra:modular_double" which could be a pickaxe too.

Describe the solution you'd like
Add a config option for additional axes that support NBT data. If a items contains for NBT then needed thats ok too. So as an example based on CraftTweaker syntax:

<item:tetra:modular_double>.withTag({
	"double/head_left": "double/basic_axe_left" as string, 
	"double/head_right": "double/basic_axe_right" as string
})

should accept:

<item:tetra:modular_double>.withTag({
   "double/basic_axe_right_material": "basic_axe/oak" as string, 
   "double/basic_axe_left_material": "basic_axe/stone" as string, 
   "double/handle": "double/basic_handle" as string, 
   honing_progress: 280 as int, "double/head_left": "double/basic_axe_left" as string, 
   HideFlags: 1 as int, "double/head_right": "double/basic_axe_right" as string, 
   id: "50f3c9f7-04ae-4de1-b5b5-f4c40a486c91" as string, 
   "double/basic_handle_material": "basic_handle/stick" as string})
.withDamage(1)

I am not sure how to do NBT data in configs but it should work somehow as recipes can also contain NBT information:
https://github.com/yanny7/StoneAge/blob/1.16/src/main/resources/data/stone_age/recipes/stone_tablet.json

This could not only be helpful to Tetra but also to Tinkers Construct and other modular tools mods.

@Terpo Terpo added the enhancement New feature or request label Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant