Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change compile with api in build.gradle #416

Open
bshubham80 opened this issue Nov 16, 2022 · 1 comment
Open

Change compile with api in build.gradle #416

bshubham80 opened this issue Nov 16, 2022 · 1 comment

Comments

@bshubham80
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-orientation/android/build.gradle b/node_modules/react-native-orientation/android/build.gradle
index e09fb27..b35d87c 100644
--- a/node_modules/react-native-orientation/android/build.gradle
+++ b/node_modules/react-native-orientation/android/build.gradle
@@ -16,5 +16,5 @@ android {
 }
 
 dependencies {
-    compile "com.facebook.react:react-native:+"
+    api "com.facebook.react:react-native:+"
 }

This issue body was partially generated by patch-package.

@xtealer
Copy link

xtealer commented Nov 25, 2022

implementation is good as well, but it seems that api is the way to go since the react-native sdk version targeted is the one available on the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants