-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add Branch Option for Remote Repository Packing #195
Comments
Hi, @tranquochuy645 ! I've quickly reviewed the code and it looks great! Just one suggestion: since this is paired with the I'll review the code more thoroughly later. Really appreciate your contribution! |
Hey @yamadashy, Thanks for the feedback! I’ve updated the PR to rename the option to --remote-branch for consistency with the --remote option, as you suggested. Let me know if anything else needs adjustment 👍 |
Hi, @tranquochuy645 You can check out the release notes here: |
Hey guys, it seems the commit option isn't supported? |
Hello @darrelladjei , Thank you for reporting this issue. I'm currently working on another PR to fix this issue! |
Hey @tranquochuy645 thanks for addressing, let me know if I should also take a look! Haven't contributed before but willing to help get this over the line! |
Thanks for your interest and willingness to help! I have created a draft PR #212 . It works perfectly on my machine, but it still needs additional unit tests, and I’m not entirely sure how to write those properly. |
Nice thanks, thanks for that! It wasn't working for my use case when i ran it locally (using the Comfy_UI example from a few messages above). |
Hey @darrelladjei, Thanks for your feedback! I’ve tested your use case, and I can confirm that my implementation doesn't work with the short commit hash (b188a6c), but it does work with the full hash (b188a6cb39b512a9c6da7235b880af42c78ccd0d). This issue arises because git fetch doesn't support short commit hashes. However, I believe this limitation is acceptable given the circumstances. The goal of my implementation is to avoid fetching any git history, and the optimal approach for this has been discussed in a previous Stack Overflow thread here: How to clone git repository with a specific revision/changeset. Regarding your PR, I don't think git checkout will work for commits on branches other than the default branch unless you perform a git fetch first. That said, the tests are great, and I plan to adapt some of them. Thanks again! |
Hello @yamadashy ,
I'm new to this project but I'm willing to help creating a PR. I think it would be beneficial to add an option to select a specific commit ID or branch when packing a remote repository.
Current Behavior:
When packing a remote repository, the process uses the default branch.
Proposed Feature:
Add a branch option to the packing process, allowing users to select a specific commit ID or branch to pack.
Potential Implementation:
The text was updated successfully, but these errors were encountered: