Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup Best Candidate Calc Inconsistent with Equal Cost #766

Open
ryankwagner opened this issue Mar 9, 2021 · 0 comments
Open

Rollup Best Candidate Calc Inconsistent with Equal Cost #766

ryankwagner opened this issue Mar 9, 2021 · 0 comments

Comments

@ryankwagner
Copy link
Collaborator

ryankwagner commented Mar 9, 2021

Found that given two rollups:
(dr_stats_hourly,Druid,1600,9993,8675309)

(dr_teacher_stats_hourly,Druid,1600,9992,8675309)

With same cost (1600) and Engine (Druid), Level is not factored into old logic:
if (a._2 == b._2) { if (a._4 == b._4) { a._3 < b._3 } else { a._4 < b._4 } } else { if (a._5 == b._5) { a._3 < b._3 } else { a._5 < b._5 } }

This case drops into
if (a._5 == b._5) { a._3 < b._3 }

This if-clause which causes errors.

Adding in the same check made on the IF case fixes this.

#765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant