Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Dim Only Query: Schema required filter validation in request #649

Open
pranavbhole opened this issue May 17, 2020 · 0 comments
Open

Comments

@pranavbhole
Copy link
Contributor

pranavbhole commented May 17, 2020

Right now, request model is not validating the schema required filters for Dim Only Query.
The code block to validate the schema required filters is only applied when we have fact best candidate defined. Adding this missing feature.

  • If you are querying dim only data then you need to have the schema required fields as filter.

  • If you are querying top level dim like ads or ad assets and then it will search all the related dimensions and create flatmap of schema required fields and assert on it. (Had to do this because, In some case we specify schema required fields only in the Lower level dim)

  • Also asserting that Schema required filter can only have In Or = filter to pass criteria, so that no request can run NOT IN filter on Advertiser ID and get all data.

  • Exposing common methods in the registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant