Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Settings Page Choose File Types #48

Closed
DuckDivers opened this issue Aug 28, 2021 · 1 comment
Closed

Admin Settings Page Choose File Types #48

DuckDivers opened this issue Aug 28, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@DuckDivers
Copy link

DuckDivers commented Aug 28, 2021

Hi.

Nice work on this plugin.

I think it would be helpful to add a "Uncheck All" on the choose file type settings page. Since there's 323 of them. Maybe add a <button> under the show all toggle, and then simply use:

jQuery('#column_name input[type="checkbox"]').prop('checked', false);

Additionally,

This text "Links to YouTube, Facebook, Twitter and other services inserted in the comment text will be automatically embedded." I think it would be nicer to have as an option that is editable by end users, or at least filterable vs having to use gettext hook to update.

I'd be happy to contribute if you'd like.

@yadenis
Copy link
Owner

yadenis commented Sep 9, 2021

Hello @DuckDivers
I'm sorry to be late with the reply.

I think it would be helpful to add a "Uncheck All" on the choose file type settings page

At the moment, you can Check All/Uncheck All by clicking on the type title.
But, apparently, this is not enough user friendly, since such a question has appeared :)

About the button. Perhaps it makes sense to add a checkbox to the type name? Like it is implemented, for example, on the screen for editing posts list.
2021-09-09_232648

at least filterable vs having to use gettext hook to update.

Code:

function filter_gettext( $translation, $text, $domain ) {
	if ( $text === 'Links to YouTube, Facebook, Twitter and other services inserted in the comment text will be automatically embedded.' && $domain === 'dco-comment-attachment' ) {
		$translation = 'My text.';
	}

	return $translation;
}

add_filter( 'gettext', 'filter_gettext', 10, 3 );

Result:
2021-09-09_234157

I think it would be nicer to have as an option that is editable by end users,

I have an issue #22 about it. I plan to place these settings in the customizer in future releases. Feel free to comment 🙌.

@yadenis yadenis added the enhancement New feature or request label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants