Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix android 28 no toast bug #37

Open
wants to merge 1 commit into
base: lib
Choose a base branch
from
Open

fix android 28 no toast bug #37

wants to merge 1 commit into from

Conversation

xinwii
Copy link

@xinwii xinwii commented Dec 20, 2018

update target version to 28

Copy link

@chankruze chankruze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a library for android application.There is no need of this app.
These are handled by the project app gradle itself.

By the way everything seems to be ok.But only updating target android version don't make the app compatible. But in this case it will work.

This gradle change can fix all the failed checks for travis ci (#35 )

@lucazin
Copy link

lucazin commented Jun 10, 2019

I have compileSDK 28 minSDK 21 targetsdk 28 and not work in my project in android pie, just in 8.1 and 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants