Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum for toast type #26

Open
pkarira opened this issue Apr 4, 2017 · 2 comments
Open

enum for toast type #26

pkarira opened this issue Apr 4, 2017 · 2 comments

Comments

@pkarira
Copy link

pkarira commented Apr 4, 2017

It would be better to use enum for toast type , storing them as integer seems to be a bad practice .
@yadav-rahul
Copy link
Owner

@deep110 What do you think about this? Also, Can you please review this PR #27 .

@deep110
Copy link

deep110 commented Apr 5, 2017 •
edited
Loading

@yadav-rahul enums are just used to group specific type of constants like that is done in #27. It is purely implementation viewpoint, there is no right or wrong from coding point of view.
Though I would advise to switch to enum type. Because it would look cleaner and differentiate between Toast length and Toast type.
And for the PR, it could be merged if you fix the error so that CI build is passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deep110 @yadav-rahul @pkarira