New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for uploader `file_name` option set to a string #50

Open

y9v opened this issue Feb 3, 2017 · 0 comments

Assignees

Labels

enhancement help wanted

Milestone

Owner

y9v commented Feb 3, 2017

After it has been deprecated in #49, we can remove support for it, and get rid of the conditional.

Additionally we could clean up the specs for generating the file name.

y9v added enhancement help wanted labels

y9v added this to the v2.3.5 milestone

y9v self-assigned this

y9v modified the milestones: v2.3.5, v2.4.0

y9v mentioned this issue

Should not mutate options[:file_name] #55

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment