Fix possible error in logic and sed cleanup #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the sed expression: since you're only accessing the variables that start with 'Slave_' it might make more sense to just look those ones up. I also found a problem with the logic, since is_replication_ok() returns 1 if everything is correct, and that value triggers setup_replication(). I changed the values for the output on that function and the reference inside setup_replication() as well.
Replaced the sed expression: since you're only accessing the variables that start with 'Slave_' it might make more sense to just look those ones up. I also found a problem with the logic, since is_replication_ok() returns 1 if everything is correct, and that value triggers setup_replication(). I changed the values for the output on that function and the reference inside setup_replication() as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the sed expression: since you're only accessing the variables that start with 'Slave_' it might make more sense to just look those ones up.
I also found a problem with the logic unless I am getting it wrong: is_replication_ok() returns 1 if everything is correct, and that value triggers setup_replication(). I changed the values for the output on that function and the reference inside setup_replication() as well to 0, and now the script behaves as expected.