Fix warnings.

Author: SebastianStehle

.editorconfig

@@ -30,6 +30,8 @@ dotnet_diagnostic.SA1101.severity = none # Prefix local calls with this
 
 # Ordering rules
 dotnet_diagnostic.SA1200.severity = suggestion # Using directives should be placed correctly
+dotnet_diagnostic.SA1201.severity = none       # SA1201: Elements should appear in the correct order
+dotnet_diagnostic.SA1202.severity = none       # SA1202: Elements should be ordered by access
 dotnet_diagnostic.SA1204.severity = suggestion # Static elements should appear before instance elements
 
 # Maintainability rules
@@ -45,3 +47,8 @@ dotnet_diagnostic.SA1601.severity = suggestion # Partial elements should be docu
 dotnet_diagnostic.SA1602.severity = suggestion # Enumeration items should be documented
 dotnet_diagnostic.SA1633.severity = none # File should have header
 
+# CS1591: Missing XML comment for publicly visible type or member
+dotnet_diagnostic.CS1591.severity = none
+
+# MA0055: Do not use finalizer
+dotnet_diagnostic.MA0055.severity = none

Tests/YDotNet.Tests.Unit/Maps/GetTests.cs

@@ -334,9 +334,9 @@ public void GetNewKeyReturnsNull()
         var map = doc.Map("map");
         var transaction = doc.WriteTransaction();
 
-        foreach (var value in values)
+        foreach (var (kez, value) in values)
         {
-            map.Insert(transaction, value.Key, value.Value);
+            map.Insert(transaction, kez, value);
         }
 
         return (map, transaction);

YDotNet.Extensions/InputFactory.cs

@@ -19,7 +19,7 @@ public static Input FromJson(JsonElement json)
 
         static Input ConvertObject(JsonElement element)
         {
-            return Input.Object(element.EnumerateObject().ToDictionary(x => x.Name, x => ConvertValue(x.Value)));
+            return Input.Object(element.EnumerateObject().ToDictionary(x => x.Name, x => ConvertValue(x.Value), StringComparer.Ordinal));
         }
 
         static Input ConvertArray(JsonElement element)

YDotNet.Server.Redis/Internal/LoggerTextWriter.cs

@@ -1,5 +1,5 @@
-using Microsoft.Extensions.Logging;
 using System.Text;
+using Microsoft.Extensions.Logging;
 
 namespace YDotNet.Server.Redis.Internal;
 

YDotNet.Server.Redis/RedisDocumentStorage.cs

@@ -43,8 +43,7 @@ private async Task InitializeAsync(RedisConnection redisConnection)
         return item;
     }
 
-    public async ValueTask StoreDocAsync(string name, byte[] doc,
-        CancellationToken ct = default)
+    public async ValueTask StoreDocAsync(string name, byte[] doc, CancellationToken ct = default)
     {
         if (database == null)
         {

YDotNet.Server.WebSockets/YDotNetSocketMiddleware.cs

@@ -258,7 +258,7 @@ private async Task HandleAwarenessAsync(ClientState state, AwarenessMessage awar
         }
     }
 
-    private async Task SendPendingUpdatesAsync(WebSocketEncoder encoder, ClientState state, CancellationToken ct)
+    private static async Task SendPendingUpdatesAsync(WebSocketEncoder encoder, ClientState state, CancellationToken ct)
     {
         while (state.PendingUpdates.TryDequeue(out var pendingDiff))
         {

YDotNet.Server/DefaultDocumentManager.cs

@@ -55,8 +55,7 @@ public async ValueTask<byte[]> GetStateVectorAsync(
         }).ConfigureAwait(false);
     }
 
-    public async ValueTask<byte[]> GetUpdateAsync(DocumentContext context, byte[] stateVector,
-        CancellationToken ct = default)
+    public async ValueTask<byte[]> GetUpdateAsync(DocumentContext context, byte[] stateVector, CancellationToken ct = default)
     {
         var container = cache.GetContext(context.DocumentName);
 
@@ -69,8 +68,7 @@ public async ValueTask<byte[]> GetUpdateAsync(DocumentContext context, byte[] st
         }).ConfigureAwait(false);
     }
 
-    public async ValueTask<UpdateResult> ApplyUpdateAsync(DocumentContext context, byte[] stateDiff,
-        CancellationToken ct = default)
+    public async ValueTask<UpdateResult> ApplyUpdateAsync(DocumentContext context, byte[] stateDiff, CancellationToken ct = default)
     {
         var container = cache.GetContext(context.DocumentName);
 
@@ -103,8 +101,7 @@ await callback.OnDocumentChangedAsync(new DocumentChangedEvent
         return result;
     }
 
-    public async ValueTask UpdateDocAsync(DocumentContext context, Action<Doc> action,
-        CancellationToken ct = default)
+    public async ValueTask UpdateDocAsync(DocumentContext context, Action<Doc> action, CancellationToken ct = default)
     {
         var container = cache.GetContext(context.DocumentName);
 
@@ -129,8 +126,7 @@ await callback.OnDocumentChangedAsync(new DocumentChangedEvent
         }
     }
 
-    public async ValueTask PingAsync(DocumentContext context, ulong clock, string? state = null,
-        CancellationToken ct = default)
+    public async ValueTask PingAsync(DocumentContext context, ulong clock, string? state = null, CancellationToken ct = default)
     {
         if (users.AddOrUpdate(context.DocumentName, context.ClientId, clock, state, out var newState))
         {

YDotNet.Server/Events.cs

@@ -2,6 +2,7 @@
 
 #pragma warning disable MA0048 // File name must match type name
 #pragma warning disable SA1402 // File may only contain a single type
+#pragma warning disable SA1649 // File name should match first type name
 
 namespace YDotNet.Server;
 

YDotNet.Server/Internal/ConnectedUsers.cs

@@ -4,9 +4,9 @@ namespace YDotNet.Server.Internal;
 
 public sealed class ConnectedUsers
 {
-    private readonly ConcurrentDictionary<string, Dictionary<ulong, ConnectedUser>> users = new();
+    private readonly ConcurrentDictionary<string, Dictionary<ulong, ConnectedUser>> users = new(StringComparer.Ordinal);
 
-    public Func<DateTime> Clock = () => DateTime.UtcNow;
+    public Func<DateTime> Clock { get; set; } = () => DateTime.UtcNow;
 
     public IReadOnlyDictionary<ulong, ConnectedUser> GetUsers(string documentName)
     {

YDotNet.Server/Internal/DelayedWriter.cs

@@ -19,7 +19,7 @@ public DelayedWriter(TimeSpan delay, TimeSpan delayMax, Func<Task> action)
         writeTimer = new Timer(_ => Write(), null, Timeout.Infinite, Timeout.Infinite);
     }
 
-    public Func<DateTime> Clock = () => DateTime.UtcNow;
+    public Func<DateTime> Clock { get; set; } = () => DateTime.UtcNow;
 
     public async Task FlushAsync()
     {