Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for multiple or multiline "custom" #25

Closed
noabody opened this issue Jan 7, 2023 · 3 comments
Closed

Feature request: Add support for multiple or multiline "custom" #25

noabody opened this issue Jan 7, 2023 · 3 comments
Assignees

Comments

@noabody
Copy link

noabody commented Jan 7, 2023

We can work around the Keywords issue from #20 with --custom but there doesn't seem to be a way to use multiple. Only the last is honored, and it isn't possible to inject \n to break the line into multiple parts.

Neither of these produce StartupWMClass and Keywords:

gendesk -f -n --name=name --comment='comment' --genericname='comment' --custom='StartupWMClass=class' --custom='Keywords=this;that;' --exec=exec --icon=icon --terminal=false --categories='This;That' --startupnotify=false --pkgname=name
gendesk -f -n --name=name --comment='comment' --genericname='comment' --custom='StartupWMClass=class\nKeywords=this;that;' --exec=exec --icon=icon --terminal=false --categories='This;That' --startupnotify=false --pkgname=name
@noabody noabody changed the title Add support for multiple or multiline "custom" Feature request: Add support for multiple or multiline "custom" Jan 7, 2023
@xyproto xyproto self-assigned this Jan 7, 2023
@xyproto
Copy link
Owner

xyproto commented Jan 7, 2023

Thanks for reporting! Supporting multiple custom lines might be a good idea.

I guess there is a crossover point where enough custom lines means that the contents should be piped directly to the .desktop file instead.

And StartupWM could have a dedicated flag.

There are many possible paths.

@noabody
Copy link
Author

noabody commented Jan 8, 2023

I agree. Looking at the specs, there are 24 recognized keys that can reside within the desktop file. Currently, gendesk supports 12 and one custom.

I believe the most common ones should be implemented, without question. Having multiple, or a multi-line, custom should be adequate for those remaining.

@noabody
Copy link
Author

noabody commented May 15, 2023

I agree.

@noabody noabody closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants