Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no react 18 support #27

Open
automotionShmuel opened this issue Jan 4, 2023 · 4 comments
Open

no react 18 support #27

automotionShmuel opened this issue Jan 4, 2023 · 4 comments

Comments

@automotionShmuel
Copy link

automotionShmuel commented Jan 4, 2023

npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"^18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.0.0 || ^16.0.0" from [email protected]

@sparker888
Copy link

Were you able to solve this issue? I was psyched to find this package today then my heart sank when I saw your issue. My app is built with React 18.0.0 of course. Any guidance is appreciated!

@automotionShmuel
Copy link
Author

automotionShmuel commented Apr 3, 2023

@sparker888 ,
I apologize that I don't recall what the resolution was, but I do have it working in my React 18 project. It's possible that maybe I needed to install with legacy peer dependencies like this: npm i react-jotform-embed --legacy-peer-deps instead. Keep in mind, that if you install like this, all future packages will require --legacy-peer-deps as well (which I have done without any problems).

@xurei
Copy link
Owner

xurei commented May 13, 2023

I updated the package.json file to allow any version of React above 15. It should solve the issue.
Can you confirm that it works now ? I don't have a test project for this anymore.

@ahmednabik
Copy link

@xurei I can confirm it is working fine with React. 18.0.0 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants