Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Cannot discern between tests with long names that share a starting string #33

Closed
AArnott opened this issue Nov 24, 2015 · 13 comments
Closed
Labels

Comments

@AArnott
Copy link

AArnott commented Nov 24, 2015

The font is so large, with no word wrap in the UI, that if I have two or more tests that all start with the same word or two, I can't discern between them. No UI I can find will display the full test name.

For example, here is a screenshot that demonstrates no test name is shown. When the test happens to fail I can usually figure out the test name from the stack trace. But when a test passed, or before I run it, I can't tell.

missingformatmessage

@clairernovotny
Copy link
Member

This is a partial dup of #28.

I agree, def needs something better here. Smaller size and word-wrap.

@AArnott
Copy link
Author

AArnott commented Nov 24, 2015

Ah yes, I'd say it's a dupe of #28. feel free to close unless you see something unique in this report.

@clairernovotny
Copy link
Member

I'll keep this one open as dealing with the length of the test names. #28 also has an android component to it with the data being cleared on rotation

@clairernovotny
Copy link
Member

I have a fix for the test result page for Wpa81/Xamarin, etc. That'll wrap the test name.

For UWP on the phone though, it can scroll left/right if the text is too long, is that ok? Do you need wrapping there?

@AArnott
Copy link
Author

AArnott commented Nov 24, 2015

Scrolling---as in I can drag with my finger horizontally? Yes, that's fine.

@AArnott AArnott closed this as completed Nov 24, 2015
@AArnott AArnott reopened this Nov 24, 2015
@clairernovotny
Copy link
Member

Just pushed 46b3bfe with the fix; should be in the devices CI feed in a few minutes.

@clairernovotny
Copy link
Member

Fix is in current CI build and will be in next NuGet release

@AArnott
Copy link
Author

AArnott commented Nov 25, 2015

Is this fixed for passing tests with no output?

@clairernovotny
Copy link
Member

It should be in the next ci build, 11?

@AArnott
Copy link
Author

AArnott commented Nov 25, 2015

cool. I'll check it out.

@kentcb
Copy link
Contributor

kentcb commented Nov 28, 2015

Out of interest, does this also set iOS 9's CellLayoutMarginsFollowReadableWidth property to false because it ludicrously defaults to true, which breaks existing table views so that they are essentially squashed horizontally. Rotating my iPad to landscape mode does absolutely nothing anymore to help me see more of the test names.

@clairernovotny
Copy link
Member

I'm not sure....all of the non-UWP UI is done by Xamarin Forms and I have no idea what it's iOS renderer does in this case.

What I did do was to not use the Title element of the ContentPage and instead use a separate Label within the StackLayout. That appears to have better wrapping characteristics.

Always happy to take PR's to make things better (including any platform-specific Xam Forms renderers).

@kentcb
Copy link
Contributor

kentcb commented Nov 28, 2015

OK, thanks @onovotny

Yeah, XF doesn't override the default. The fact that this new property screws up existing app layouts when transitioning from iOS 8 to 9 leaves a bad taste in my mouth. They could easily (and more reasonably) added the property and made it opt-in. It's almost like Apple want to force developers to maintain their license just to make minor changes to apps that would otherwise function just fine in iOS 9. Wait, no, it's exactly like that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants