Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add support for NDJSON, log message to pushed s3 key & compression #18

Open
diman82 opened this issue May 16, 2023 · 0 comments

Comments

@diman82
Copy link

diman82 commented May 16, 2023

Hi @xtream1101

Please add support for:

  1. NDJSON format (basically adding a new-line separator), e.g.
def construct_jsonl_str(items) -> str:
    json_str = ''
    for item in items:
        json_str += json.dumps(item) + os.linesep  # added workaround to convert to NDJSON
    return json_str
  1. log message with s3 key to be put (probably somewhere here)

  2. Please add compression to concatenated file

P.S I can contribute the requestd above logic by myself, if possible

@diman82 diman82 changed the title feature request: add support for NDJSON & add log message with s3 key to be put feature request: add support for NDJSON, log message to pushed s3 key & compression May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant