From 3dc6e4a8bfe82a1400948b8bc0f54e278e026c75 Mon Sep 17 00:00:00 2001
From: Roman Podoliaka <roman.podoliaka@gmail.com>
Date: Tue, 26 Nov 2024 07:21:27 +0000
Subject: [PATCH] ci: fix build error on windows

See https://github.com/sfackler/rust-openssl/issues/2149.

Apparently, in the Windows runner, commands executed in a `run` block
will use the version of Perl built into MinGW instead of the one
installed in the system, which breaks the openssl build because one of
the expected Perl modules can't be found.

There are different ways to fix this. The one suggested in this PR is
returning back to using the cargo action for "normal" (not cross
compilation) builds like it used to work before. My understanding is
that it helps by running cargo directly as opposed to running it from
Bash.

Alternatively, we could bypass the corresponding build steps in openssl
by providing locations of openssl source code via environment variables
like it is suggested in the rust-openssl issue linked above.
---
 .github/workflows/release.yml | 43 ++++++++++++++++++++---------------
 1 file changed, 25 insertions(+), 18 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 22251f5..12159fd 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -75,33 +75,40 @@ jobs:
       - name: Setup PostgreSQL
         uses: ikalnytskyi/action-setup-postgres@v6
 
-      - id: build
+      - id: detect_host
         run: |
-          export HOST=$(rustc -vV | grep host: | awk '{print $2}')
-          if [ "$HOST" = "$TARGET" ]; then
-            cargo build --release --target ${TARGET}
-          else
-            cargo install cross
-            cross build --release --target ${TARGET}
-          fi
+          echo "host=$(rustc -vV | grep host: | awk '{print $2}')" >> $GITHUB_OUTPUT
+
+      - name: Build
+        if: ${{ steps.detect_host.outputs.host == matrix.target }}
+        uses: actions-rs/cargo@v1
+        with:
+          command: build
+          args: --release --target ${{ matrix.target }}
 
-          pushd target/${TARGET}/release
-          if [[ "$TARGET" =~ "windows" ]]; then
-            7z a $ASSET_NAME xsnippet-api.exe
+      - name: Build (cross-compile)
+        if: ${{ steps.detect_host.outputs.host != matrix.target }}
+        run: |
+          cargo install cross
+          cross build --release --target ${{ matrix.target }}
+
+      - id: upload
+        name: Upload artifacts
+        run: |
+          pushd target/${{ matrix.target }}/release
+          if [[ "${{ matrix.target }}" =~ "windows" ]]; then
+            7z a ${{ matrix.name }} xsnippet-api.exe
           else
-            tar cvzf $ASSET_NAME xsnippet-api
+            tar cvzf ${{ matrix.name }} xsnippet-api
           fi
-          gh release upload $RELEASE_TAG $ASSET_NAME
+          gh release upload ${{ needs.create_release.outputs.release_tag }} ${{ matrix.name }}
           popd
 
-          echo "asset_path=target/${TARGET}/release/$ASSET_NAME" >> $GITHUB_OUTPUT
+          echo "asset_path=target/${{ matrix.target }}/release/${{ matrix.name }}" >> $GITHUB_OUTPUT
         env:
-          ASSET_NAME: ${{ matrix.name }}
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GH_REPO: ${{ env.GITHUB_REPOSITORY }}
-          TARGET: ${{ matrix.target }}
-          RELEASE_TAG: ${{ needs.create_release.outputs.release_tag }}
 
       - uses: actions/attest-build-provenance@v1
         with:
-          subject-path: ${{ steps.build.outputs.asset_path }}
+          subject-path: ${{ steps.upload.outputs.asset_path }}