-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: No matching distribution found for diffq>=0.2.1 #14
Comments
Hello @zeddan, sadly Github doesn't provide machines with macos 12 for the automated build of the DiffQ package. The same is true for It should be possible to build those packages locally but I'm not sure how to do it with Docker. |
Hello @zeddan , thank you so much for reporting this issue. As @adefossez commented there's no way right now to test the build step with MacOS 12 with GitHub Actions. It's true that they'll support the new version soon but now it's on beta (see: github/roadmap#240). I'll try to install MacOS 12 on my local machine and I've created this issue #15 to add a Github Action to test the execution of the Makefile on different platforms. It's in progress but I hope I'll add a pull request soon. |
@zeddan thanks to this issues from Mac M1 users (facebookresearch/demucs#246) I realized I had forgotten to upload source distributions for |
Hi @adefossez @zeddan , I've just upgraded my laptop to last version MacOS 12 and the process worked as expected. I've got only this error: I've created a repository in Docker Hub to store the docker image there instead of building it every time in the local environment. I hope that this change will improve the usage of the Makefile and reduce the issues related to the building process. Checkout https://hub.docker.com/r/xserrat/facebook-demucs/tags. I'm going to create a pull request to update the docker image used in the Thanks so much!! |
Thanks for looking into this issue! I re-cloned the repository and tried again, and this time it succeeds on the
@xserrat you don't happen to know something else I can try, since you have got it working? I'm running on a fresh install of MacOS 12 so it's possible that I'm missing some configuration. |
Hi @zeddan , Could you try to run the following command to build the image from scratch without cache: docker build --no-cache -t facebook/demucs:latest . Then, execute again the If the error persists, I've just merged this PR #19 related to the issue #17 to prevent possible errors when building the image. You can update the Let me know how it was! |
I think the author of |
An issue already exist: chrisstaite/lameenc#13 |
I didn't realise it was related to the new Mac M1 😄 🙏🏽 . Perfect @adefossez 🚀 |
In the meantime, as a workaround, I threw together a dockerfile that compiles https://gist.github.com/Reidsy/07db8e4d484d61f84408cab98fc24965 |
Fails like this on my Apple M1 Pro OS 12.4 |
@radostyle thanks for reporting this issue. It seems to be related with an incompatibility with the version of torchaudio that demucs is using. I'll investigate in more detail 🙏🏼 |
I'm excited to try it out. Let me know if there is something to test. |
Hi @radostyle , sorry for my delay replying about this issue. I've just merged the fix #37 that should solve the issue. Could you try it again using the version Thanks in advance. |
Closing issue after some time waiting for response. I assume it worked. |
Contact Details
[email protected]
What happened?
Hi!
Thanks for taking the time to work on dockerizing demucs 🙌
OS: macOS Monterey 12.0
Docker: 4.2.0
When trying to run a track separation the build fails on installation, please see the Relevant log output section.
However, if
RUN python3 -m pip install -e .
is replaced with manual installations like the following:the installation of
diffq
completes. Then the problem instead becomes installinglameenc
, with the following error message:What I've tried:
RUN python3 -m pip install --upgrade pip
FROM python:3.9
at the topThanks in advance!
In which operating system you found the issue?
MacOS
Relevant log output
The text was updated successfully, but these errors were encountered: