Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelise tests #4

Open
kynrai opened this issue Jun 3, 2024 · 3 comments
Open

Parallelise tests #4

kynrai opened this issue Jun 3, 2024 · 3 comments
Assignees

Comments

@kynrai
Copy link
Collaborator

kynrai commented Jun 3, 2024

The tests take a while to run, it should be possible to parallelize the tests by making them all spin up their own server

@kynrai kynrai self-assigned this Jun 3, 2024
@Lissy93
Copy link
Member

Lissy93 commented Jun 7, 2024

When there's like 30+ endpoints, would it make sense if I put each in their own dir along with their tests?

@kynrai
Copy link
Collaborator Author

kynrai commented Jun 14, 2024

this will finally make all tests parallel #42

@kynrai
Copy link
Collaborator Author

kynrai commented Jun 14, 2024

When there's like 30+ endpoints, would it make sense if I put each in their own dir along with their tests?

If the check is large enough maybe, its ok for a module to be very large, and have lots of files in it, nomarlly code navigation tools help and good naming for dot completion, it could make sense for sub packages, checks/ip checks/firewall etc but that would lead to a lot of imports in some files like server.

i think its worth it when there are so many tests as it does not affect performance and would be easier to work with, its not very golang esqu more JS where everything is a folder with index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants