Add chai-as-promised ESLint plugin (#82)

- Add `chai-as-promised` plugin to avoid bad tests.

Author: 0xCLARITY

CHANGELOG.md

@@ -9,6 +9,10 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
 
 ## [Unreleased]
 
+## 0.9.0 - June 29, 2020
+
+- Add `chai-as-promised` plugin to avoid bad tests.
+
 ## 0.8.0 - June 23, 2020
 
 - Add `eslint-plugin-array-func` to provide rules for best practices with `.map().filter().reduce()` style operations.

index.js

@@ -28,6 +28,7 @@ module.exports = {
     './rules/import',
     './rules/array-func',
     './rules/mocha',
+    './rules/chai-as-promised',
     './rules/prettier',
   ].map(require.resolve),
   rules: {},

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@xpring-eng/eslint-config-base",
-  "version": "0.8.0",
+  "version": "0.9.0",
   "description": "Xpring's base TS ESLint config, following our styleguide",
   "keywords": [
     "eslint",
@@ -27,6 +27,7 @@
     "eslint-config-prettier": "^6.11.0"
   },
   "devDependencies": {
+    "@fintechstudios/eslint-plugin-chai-as-promised": "^3.0.2",
     "@typescript-eslint/eslint-plugin": "^3.4.0",
     "@typescript-eslint/parser": "^3.4.0",
     "eslint": "^7.3.1",
@@ -43,6 +44,7 @@
     "typescript": "^3.9.3"
   },
   "peerDependencies": {
+    "@fintechstudios/eslint-plugin-chai-as-promised": "^3.0.2",
     "@typescript-eslint/eslint-plugin": "^3.4.0",
     "@typescript-eslint/parser": "^3.4.0",
     "eslint": "^7.3.1",

package.json

@@ -0,0 +1,23 @@
+module.exports = {
+  env: {
+    node: true, // Enable node global variables & Node.js scoping
+    es2020: true, // Add all ECMAScript 2020 globals and automatically set the ecmaVersion parser option to ES2020
+  },
+  parserOptions: {
+    sourceType: 'module',
+  },
+
+  plugins: ['@fintechstudios/eslint-plugin-chai-as-promised'],
+
+  rules: {
+    // Must not use await within chai-as-promised expressions
+    // https://github.com/fintechstudios/eslint-plugin-chai-as-promised/blob/master/docs/rules/no-await-in-condition.md
+    '@fintechstudios/chai-as-promised/no-unhandled-promises': 'error',
+
+    // Must handle promises returned from chai-as-promised expressions
+    // https://github.com/fintechstudios/eslint-plugin-chai-as-promised/blob/master/docs/rules/no-unhandled-promises.md
+    '@fintechstudios/chai-as-promised/no-await-in-condition': 'error',
+  },
+
+  overrides: [],
+}