From 92205e9d8fefe376435689ecfce05ba950fb9dcc Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Thu, 19 Sep 2024 17:00:12 +0900 Subject: [PATCH 01/13] Add a first workflow --- .github/workflows/main.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 .github/workflows/main.yml diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml new file mode 100644 index 0000000..6ee75a5 --- /dev/null +++ b/.github/workflows/main.yml @@ -0,0 +1,13 @@ +name: A first flow +on: + push: + branches: + - main +jobs: + first_job: + runs-on: ubuntu-latest + name: My 1st Job + steps: + - name: First thing + run: echo "This is the first thing to do" + shell: bash From cc1a6c9b71bb7b0bf9cd8d4a12f3e175324a07a5 Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Sat, 21 Sep 2024 22:12:05 -0700 Subject: [PATCH 02/13] Add C/C++ linter --- .github/workflows/main.yml | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6ee75a5..d3aef5a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -3,11 +3,31 @@ on: push: branches: - main + pull_request: + # The branches below must be a subset of the branches above + branches: [ "main" ] + schedule: + - cron: '39 17 * * 0' jobs: - first_job: + clinter: + name: A Clinter runs-on: ubuntu-latest - name: My 1st Job + permissions: + contents: read + security-events: write + actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status steps: - - name: First thing - run: echo "This is the first thing to do" - shell: bash + - name: First thing + run: echo "This is the first thing to do" + shell: bash + - name: Checkout code + uses: actions/checkout@v4 + + - name: configure + run: ./configure + - name: make + run: make + - name: make check + run: make check + - name: make distcheck + run: make distcheck From f880e7221787b468e2550f973b723aaab336f5b6 Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Sat, 21 Sep 2024 22:21:38 -0700 Subject: [PATCH 03/13] Add c/c++ linter --- .github/workflows/main.yml | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d3aef5a..deca436 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -22,12 +22,15 @@ jobs: shell: bash - name: Checkout code uses: actions/checkout@v4 - - - name: configure - run: ./configure - - name: make - run: make - - name: make check - run: make check - - name: make distcheck - run: make distcheck + - uses: cpp-linter/cpp-linter-action@v2 + id: linter + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + with: + style: 'file' # Use .clang-format config file + tidy-checks: '' # Use .clang-tidy config file + # only 'update' a single comment in a pull request's thread. + thread-comments: ${{ github.event_name == 'pull_request' && 'update' }} + - name: Fail fast?! + if: steps.linter.outputs.checks-failed > 0 + run: exit 1 From 4927b652759d58a12e87576ebf2284555cf69844 Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Sat, 21 Sep 2024 22:27:48 -0700 Subject: [PATCH 04/13] Add paths --- .github/workflows/main.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index deca436..14817c3 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,11 +1,12 @@ name: A first flow on: push: - branches: - - main + branches: [ "main" ] + paths: ['**.c', '**.cpp', '**.h', '**.hpp', '**.cxx', '**.hxx', '**.cc', '**.hh', '**CMakeLists.txt', 'meson.build', '**.cmake'] pull_request: # The branches below must be a subset of the branches above branches: [ "main" ] + paths: ['**.c', '**.cpp', '**.h', '**.hpp', '**.cxx', '**.hxx', '**.cc', '**.hh', '**CMakeLists.txt', 'meson.build', '**.cmake'] schedule: - cron: '39 17 * * 0' jobs: From cfecab50fb66cc05e4ee633253f3d26804f61a21 Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Sat, 21 Sep 2024 22:30:25 -0700 Subject: [PATCH 05/13] Trigger build on c file change --- forsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/forsp.c b/forsp.c index 04b4590..19cdd0c 100644 --- a/forsp.c +++ b/forsp.c @@ -22,6 +22,7 @@ * SOFTWARE. *******************************************************************************/ + #include #include #include From 901e3753743b3c619cd849c6d9616d204a7a6e57 Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Sun, 22 Sep 2024 00:08:42 -0700 Subject: [PATCH 06/13] Switch to local runner for test --- .github/workflows/main.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 14817c3..03c2612 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,7 +12,8 @@ on: jobs: clinter: name: A Clinter - runs-on: ubuntu-latest + runs-on: self-hosted + # runs-on: ubuntu-latest permissions: contents: read security-events: write From 43ac377cfd873076e46f88f23b404073f925c1ac Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Sun, 22 Sep 2024 00:09:45 -0700 Subject: [PATCH 07/13] remove an empty ws --- forsp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/forsp.c b/forsp.c index 19cdd0c..04b4590 100644 --- a/forsp.c +++ b/forsp.c @@ -22,7 +22,6 @@ * SOFTWARE. *******************************************************************************/ - #include #include #include From 29166eff9d339efaac1e9c4c4e3e2a4133ce3c9a Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Sun, 22 Sep 2024 00:11:11 -0700 Subject: [PATCH 08/13] Switch back to local runner --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 03c2612..23d933a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,8 +12,8 @@ on: jobs: clinter: name: A Clinter - runs-on: self-hosted - # runs-on: ubuntu-latest + # runs-on: self-hosted + runs-on: ubuntu-latest permissions: contents: read security-events: write From 93b33499e6028a054f2d147302f3167f2880321a Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Sun, 22 Sep 2024 00:11:50 -0700 Subject: [PATCH 09/13] Cleanup excess comment --- .github/workflows/main.yml | 1 - forsp.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 23d933a..14817c3 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,7 +12,6 @@ on: jobs: clinter: name: A Clinter - # runs-on: self-hosted runs-on: ubuntu-latest permissions: contents: read diff --git a/forsp.c b/forsp.c index 04b4590..19cdd0c 100644 --- a/forsp.c +++ b/forsp.c @@ -22,6 +22,7 @@ * SOFTWARE. *******************************************************************************/ + #include #include #include From 499d046696690f5ea41647dc2b3c4f928961f19e Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Mon, 23 Sep 2024 09:46:44 -0700 Subject: [PATCH 10/13] Attempt to add the native code build --- .github/workflows/main.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 14817c3..1f74806 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -23,6 +23,9 @@ jobs: shell: bash - name: Checkout code uses: actions/checkout@v4 + - name: First thing + run: echo "Run the build" || ./build.sh + shell: bash - uses: cpp-linter/cpp-linter-action@v2 id: linter env: From c674c228b0594e5b14dab7de2f2eecd3d6389932 Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Mon, 23 Sep 2024 10:04:16 -0700 Subject: [PATCH 11/13] Remove lf --- forsp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/forsp.c b/forsp.c index 19cdd0c..04b4590 100644 --- a/forsp.c +++ b/forsp.c @@ -22,7 +22,6 @@ * SOFTWARE. *******************************************************************************/ - #include #include #include From e4c39b51483ffa35fa74fd46e5fce1e7ec0c3a62 Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Mon, 23 Sep 2024 10:06:41 -0700 Subject: [PATCH 12/13] Get proper build going --- .github/workflows/main.yml | 2 +- forsp.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1f74806..ea6c777 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -24,7 +24,7 @@ jobs: - name: Checkout code uses: actions/checkout@v4 - name: First thing - run: echo "Run the build" || ./build.sh + run: (echo "Run the build" && ./build.sh) || echo "Build failure" shell: bash - uses: cpp-linter/cpp-linter-action@v2 id: linter diff --git a/forsp.c b/forsp.c index 04b4590..5cd7c90 100644 --- a/forsp.c +++ b/forsp.c @@ -30,6 +30,7 @@ #include #include + #define FAIL(...) do { fprintf(stderr, "FAIL: "); fprintf(stderr, __VA_ARGS__); fprintf(stderr, "\n"); abort(); } while (0) /******************************************************************* From cdc4d64e11d59f26897fc5af21c67e7781dba68c Mon Sep 17 00:00:00 2001 From: David J Kordsmeier Date: Mon, 23 Sep 2024 10:10:09 -0700 Subject: [PATCH 13/13] Remove the extra echo --- .github/workflows/main.yml | 4 ++-- forsp.c | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ea6c777..79643c8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -23,8 +23,8 @@ jobs: shell: bash - name: Checkout code uses: actions/checkout@v4 - - name: First thing - run: (echo "Run the build" && ./build.sh) || echo "Build failure" + - name: Build runner + run: ./build.sh || echo "Build failure" shell: bash - uses: cpp-linter/cpp-linter-action@v2 id: linter diff --git a/forsp.c b/forsp.c index 5cd7c90..04b4590 100644 --- a/forsp.c +++ b/forsp.c @@ -30,7 +30,6 @@ #include #include - #define FAIL(...) do { fprintf(stderr, "FAIL: "); fprintf(stderr, __VA_ARGS__); fprintf(stderr, "\n"); abort(); } while (0) /*******************************************************************