Work around a Blizzard bug with the button highlighting when mouseovering

the bag buttons by keeping BagSlot.OnEnter and BagSlot.OnLeave registere.
always. Fix #49

Author: mbattersby

ContainerPanel.lua

@@ -160,11 +160,16 @@ function LiteBagContainerPanelMixin:OnHide()
     LB.db.UnregisterAllCallbacks(self)
 
     ContainerFrameCombinedBagsMixin.OnHide(self)
+    -- Reregister these to keep them registered. Work around a Blizzard bug where
+    -- closing the bags with a keybind while the mouse is over a bagbutton will leave
+    -- the slots highlighted forever.
+    EventRegistry:RegisterCallback("BagSlot.OnEnter", self.OnBagSlotEnter, self)
+    EventRegistry:RegisterCallback("BagSlot.OnLeave", self.OnBagSlotLeave, self)
 
     -- UpdateNewItemList is broken in DF 10.0 and only clears the backpack
     -- on a combined frame. Fix it up ourselves.
     for _, itemButton in self:EnumerateValidItems() do
-        C_NewItems.RemoveNewItem(itemButton:GetBagID(), itemButton:GetID());
+        C_NewItems.RemoveNewItem(itemButton:GetBagID(), itemButton:GetID())
     end
 
     self:UnregisterEvent("PLAYERBANKSLOTS_CHANGED")
@@ -364,7 +369,7 @@ function LiteBagContainerPanelMixin:UpdateMiscellaneousFrames()
     if self:MatchesBagID(Enum.BagIndex.Bank) then
         self:GetParent():SetPortraitToUnit('npc')
     elseif self:MatchesBagID(Enum.BagIndex.Backpack) then
-        self:GetParent():SetPortraitToAsset("Interface/Icons/Inv_misc_bag_08");
+        self:GetParent():SetPortraitToAsset("Interface/Icons/Inv_misc_bag_08")
     else
         self:GetParent():SetPortraitToBag(self.bagIDs[1])
     end
@@ -384,7 +389,7 @@ function LiteBagContainerPanelMixin:OnTokenWatchChanged()
 end
 
 function LiteBagContainerPanelMixin:SetTokenTracker(tokenFrame)
-        -- tokenFrame:SetParent(self);
+        -- tokenFrame:SetParent(self)
         -- tokenFrame:SetIsCombinedInventory(true)
 end
 

Core.lua

@@ -81,7 +81,7 @@ local REPLACEMENT_GLOBALS = {
             end
 
             OpenBackpack()
-            EventRegistry:TriggerEvent("ContainerFrame.OpenAllBags");
+            EventRegistry:TriggerEvent("ContainerFrame.OpenAllBags")
         end,
 
     ToggleAllBags =
@@ -131,7 +131,7 @@ local HOOKED_GLOBALS = {
             FRAME_THAT_OPENED_BAGS = nil
 
             local wasShown = CloseBackpack()
-            EventRegistry:TriggerEvent("ContainerFrame.CloseAllBags");
+            EventRegistry:TriggerEvent("ContainerFrame.CloseAllBags")
             return wasShown
         end,
 

Frame.lua

@@ -167,7 +167,7 @@ function LiteBagFrameMixin:ShowPanel(n)
 end
 
 function LiteBagFrameMixin:OnLoad()
-    self:SetPortraitTextureSizeAndOffset(36, -4, 1);
+    self:SetPortraitTextureSizeAndOffset(36, -4, 1)
     self.Tabs[1]:SetText(self.panels[1].Title)
     PanelTemplates_SetNumTabs(self, 1)
     PanelTemplates_SetTab(self, 1)