Sonarqube fixes; clean up TODOs

Author: jearley-captech

jsonpath/src/main/java/io/github/xmljim/json/jsonpath/compiler/PathCompiler.java

@@ -166,7 +166,6 @@ private void handleLeftParen() {
     }
 
     private void handleRightParen() {
-        //TODO: handle function logic
         if (lastEnclosure() == LEFT_PAREN) {
             popEnclosure();
             appendCurrentToToken();

jsonpath/src/main/java/io/github/xmljim/json/jsonpath/compiler/PredicateCompiler.java

@@ -17,7 +17,7 @@ class PredicateCompiler extends Compiler<Predicate<Context>> {
     private Expression right;
     private PredicateOperator operator;
     private boolean negate;
-    private boolean nestedPredicate;  //TODO: handle "nested" predicate for left/right expressions
+    private boolean nestedPredicate;
     private PredicateJoin predicateJoin = PredicateJoin.NONE;
 
     public PredicateCompiler(PathExpression expression, Global global) {
@@ -216,7 +216,6 @@ private void handleLeftParen() {
     }
 
     private void handleRightParen() {
-        //TODO: handle function logic
         if (lastEnclosure() == LEFT_PAREN) {
             popEnclosure();
             appendCurrentToToken();

jsonpath/src/main/java/io/github/xmljim/json/jsonpath/function/predicate/AbstractPredicateFunction.java

@@ -10,7 +10,6 @@
 
 import java.util.List;
 import java.util.function.Predicate;
-import java.util.stream.Stream;
 
 abstract class AbstractPredicateFunction extends AbstractJsonPathFunction implements PredicateFunction {
     public AbstractPredicateFunction(String name, List<Argument<?, ?>> arguments, Global global) {
@@ -29,15 +28,4 @@ Predicate<Context> getPredicate(String name) {
         return getPredicateArgument(name).element();
     }
 
-    public Stream<Context> testPredicate(String name, Context input) {
-        Predicate<Context> predicate = getPredicate(name);
-
-        if (input.type().isArray()) {
-            return input.stream().filter(predicate);
-        } else if (input.type().isObject()) {
-            return predicate.test(input) ? Stream.of(input) : Stream.empty();
-        }
-        //TODO: revisit this
-        return Stream.empty();
-    }
 }

parser/src/main/java/io/github/xmljim/json/parser/util/ByteConstants.java

@@ -151,7 +151,7 @@ public class ByteConstants {
     public static final byte END_ARRAY = RIGHT_SQUARE_BRACKET;
 
     private ByteConstants() {
-        // TODO Auto-generated constructor stub
+        //IGNORE
     }
 
 }

parser/src/main/java/io/github/xmljim/json/parser/util/ByteSequence.java

@@ -60,7 +60,7 @@ public class ByteSequence {
      * Private constructor. Use one of the static methods to instantiate the ByteSequence.
      */
     private ByteSequence() {
-        // TODO Auto-generated constructor stub
+        //IGNORE
     }
 
     /**

parser/src/main/java/io/github/xmljim/json/parser/util/CharConstants.java

@@ -22,7 +22,7 @@
 public class CharConstants {
 
     private CharConstants() {
-        // TODO Auto-generated constructor stub
+        //PRIVATE CONSTRUCTOR
     }
 
     public static final char TAB = '\t';

parser/src/main/java/io/github/xmljim/json/parser/util/ResizableByteBuffer.java

@@ -78,7 +78,6 @@ public static ResizableByteBuffer fromStream(InputStream inputStream) {
                 throw new JsonParserException("No bytes read");
             }
         } catch (final IOException e) {
-            // TODO Auto-generated catch block
             throw new JsonParserException(e);
         }
         buffer.add(bytes);
@@ -95,7 +94,6 @@ public static ResizableByteBuffer fromStream(InputStream inputStream, int alloca
                 buffer.trim();
             }
         } catch (final IOException e) {
-            // TODO Auto-generated catch block
             throw new JsonParserException(e);
         }