Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation - incorrect range of qlp-coeff-precision parameter #816

Open
krzotr opened this issue Mar 1, 2025 · 2 comments · May be fixed by #818
Open

Documentation - incorrect range of qlp-coeff-precision parameter #816

krzotr opened this issue Mar 1, 2025 · 2 comments · May be fixed by #818

Comments

@krzotr
Copy link

krzotr commented Mar 1, 2025

On the documentation website https://xiph.org/flac/documentation_tools_flac.html I see an incorrect range of qlp-coeff-precision parameter.

Documentation says it's between 5 and 16, but running flac v1.5.0 is must be 0 or between 5 and 15, inclusive

# https://xiph.org/flac/documentation_tools_flac.html

-q #, --qlp-coeff-precision=#
Precision of the quantized linear-predictor coefficients. This number must be in between 5 and **16**, or 0 (the default) to let encoder decide. Does nothing if using -l 0.

# flac.exe -j 8 -f -V -8 -b 4600 -r 8 --qlp-coeff-precision 16  audio-20250301_183808.wav
ERROR: invalid value '16' for qlp coeff precision (-q), must be 0 or between 5 and 15, inclusive
Type "flac" for a usage summary or "flac --help" for all options
@H2Swine
Copy link
Contributor

H2Swine commented Mar 2, 2025

My blame. Working on an improved help file already.

(The FLAC format itself forbids 16, so it is solely a documentation issue.)

H2Swine added a commit to H2Swine/flac that referenced this issue Mar 3, 2025
@H2Swine
flac.md: fix "-q" misinformation, and more.
b6d3739 
* max -q value was wrong, issue xiph#816 . Fixed that. 
* Also, reworded -m, -M for clarity, -p for consistency with -q, --lax for brevity. 
* This should have been done in the previous round: the --help text has the tagging options right after --picture. Did so here too. * But, and this should either also be fixed in the help text or be rejected: --no-utf-8 is a tagging option - aren't those encoding-only? Moved and reworded, but reject as appropriate.
@H2Swine H2Swine mentioned this issue Mar 3, 2025
Closed
H2Swine added a commit to H2Swine/flac that referenced this issue Mar 3, 2025
@H2Swine
flac.md: fix "-q" misinformation, and more.
ef4491c 
* max -q value was wrong, issue xiph#816 . Fixed that. 
* Also, reworded -m, -M for clarity, -p for consistency with -q, --lax for brevity. 
* This should have been done in the previous round: the --help text has the tagging options right after --picture. Did so here too. * But, and this should either also be fixed in the help text or be rejected: --no-utf-8 is a tagging option - aren't those encoding-only? Moved and reworded, but reject as appropriate.
@H2Swine H2Swine linked a pull request Mar 3, 2025 that will close this issue
Open
@H2Swine
Copy link
Contributor

H2Swine commented Mar 3, 2025

So I obviously messed up something. Let's see #818 , ignore what I did above that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

flac.md: fix "-q" misinformation, and more. H2Swine/flac
2 participants
@krzotr @H2Swine