Skip to content

Commit 1fef440

Browse files
authored
[25.05] github-runner: fix the nodeRuntimes option (nix-darwin#1583)
2 parents 536f951 + 1c8bcd7 commit 1fef440

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

modules/services/github-runner/service.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ in
7676

7777
config.launchd.daemons = flip mapAttrs' config.services.github-runners (name: cfg:
7878
let
79-
package = cfg.package.override (old: optionalAttrs (hasAttr "nodeRuntimes" old) { inherit (cfg) nodeRuntimes; });
79+
package = cfg.package.override { inherit (cfg) nodeRuntimes; };
8080
stateDir = mkStateDir cfg;
8181
logDir = mkLogDir cfg;
8282
workDir = mkWorkDir cfg;

tests/services-github-runners.nix

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
enable = true;
55
url = "https://github.com/nixos/nixpkgs";
66
tokenFile = "/secret/path/to/a/github/token";
7-
# We need an overridable derivation but cannot use the actual github-runner package
8-
# since it still relies on Node.js 16 which is marked as insecure.
9-
package = pkgs.hello;
107
};
118

129
test = ''

0 commit comments

Comments
 (0)