Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird naming NewSMTPClient #45

Open
IceflowRE opened this issue Aug 5, 2021 · 3 comments
Open

Weird naming NewSMTPClient #45

IceflowRE opened this issue Aug 5, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@IceflowRE
Copy link

NewSMTPClient should be NewSMTPServer or at least it should be documented, why this is how it is.

@xhit
Copy link
Owner

xhit commented Aug 5, 2021

I confirm a mistake with names. Also see #37

I will document this in next days.

@xhit xhit added the documentation Improvements or additions to documentation label Aug 5, 2021
@Foosec
Copy link

Foosec commented Nov 17, 2021

If i could add, its not just the use of the "server" variable,
a function called NewSMTPClient returns a SMTPServer
Perhaps the function should be changed to NewSMTPServer, although i understand the predicament with that aswell.

Maybe NewSMTPEndpoint?

Just my 2c

@xhit
Copy link
Owner

xhit commented Nov 18, 2021

It's time to V3 so make all your ideas here: #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants