Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tab titles reactive #3857

Open
ghsolomon opened this issue Dec 16, 2024 · 1 comment
Open

Make Tab titles reactive #3857

ghsolomon opened this issue Dec 16, 2024 · 1 comment
Labels
good-first-issue layouts small

Comments

@ghsolomon
Copy link
Contributor

Currently, the only way to change the title of a Tab is to mutate TabModel.title. This is a little counter-intuitive for dynamic tabs, such as those with badges, which one would expect to be reactive. Consider refactoring TabModel.title so that developers can provide a dynamic renderFn closure.
@amcclain
Copy link
Member

We discussed that this is a likely use of the Content type + call to elementFromContent(tab.title)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue layouts small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amcclain @ghsolomon