Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefreshButtonProps: rename model -> target #3855

Open
ghsolomon opened this issue Dec 16, 2024 · 0 comments
Open

RefreshButtonProps: rename model -> target #3855

ghsolomon opened this issue Dec 16, 2024 · 0 comments

Comments

@ghsolomon
Copy link
Contributor

Other buttons that interact with a model take the model as a descriptively named prop. I.e. ColChooserButtonProps and ColAutosizeButtonProps have gridModel. DashCanvasAddViewButtonProps has dashCanvasModel. etc.

Consider refactoring RefreshButtonProps to take target instead of model. Note that when a model (soon to be target) prop is not provided, RefreshButton defaults to using the nearest RefreshContextModel as its target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ghsolomon