Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GroupingChooser should keep transient UI state separate from the provided model #3398

Open
haynesjm42 opened this issue Jun 16, 2023 · 1 comment · May be fixed by #3420
Open

GroupingChooser should keep transient UI state separate from the provided model #3398

haynesjm42 opened this issue Jun 16, 2023 · 1 comment · May be fixed by #3420
Assignees
@haynesjm42

Comments

@haynesjm42
Copy link
Member

Currently GroupingChooserModel contains transient UI state, like whether the editor is open or closed. This results in the undesired behavior where if you have multiple groupingChooser components rendered bound to the same model, clicking on one chooser will open the editor in all choosers.

It seems like we should keep transient UI state in a local model for each component so instances like this behave as expected.

I ran into this while using the panel modal support to show a larger version of a widget, so I have 2 grouping choosers rendered sharing the same model.
@amcclain amcclain changed the title GroupingChooser should keep transient UI state separate from the provided model GroupingChooser should keep transient UI state separate from the provided model Jul 17, 2023
@haynesjm42 haynesjm42 linked a pull request Jul 18, 2023 that will close this issue
Open
6 tasks
@amcclain
Copy link
Member

@haynesjm42 and @lbwexler are going to revisit the open PR to see if we can get it closed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haynesjm42 haynesjm42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update GroupingChooser with local model for transient UI state xh/hoist-react
2 participants
@amcclain @haynesjm42