Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FontAwesome v6.0 #2889

Closed
amcclain opened this issue Feb 9, 2022 · 5 comments
Closed

Update to FontAwesome v6.0 #2889

amcclain opened this issue Feb 9, 2022 · 5 comments
Assignees
Milestone

Comments

@amcclain
Copy link
Member

amcclain commented Feb 9, 2022

Should be a drop in, enabling access to a bunch of new icons. Existing icons have been tweaked to varying degrees - we'll want to give the ones we use often in Hoist built-ins to ensure they are looking reasonable.

See https://fontawesome.com/docs/changelog/

Tried this locally today and ran into one strange issue with the faThumbtack icon, of all things. They have a mixed-case alias (thumbTack) and something with that def. in particular throws. Reported to FA support and will update this ticket with any response. Was not clear how to workaround at the moment...

This update also includes support for a new "thin" style - we can see how that looks and if we want to include that variation in our big set of included-by-default icons.

@amcclain
Copy link
Member Author

FA support having trouble replicating. They asked for a reproducible test case, but I wasn't sure how to proceed to create one.

There is some chance it relates to https://github.com/xh/hoist-dev-utils/blob/4ec3a3c1c62ad771b702c85ded163f62d8d872a7/configureWebpack.js#L443

@amcclain amcclain added this to the v48 milestone Mar 3, 2022
@TomTirapani
Copy link
Member

Wonder if this will be improved with xh/hoist-dev-utils#33? 🤔

@TomTirapani TomTirapani self-assigned this Mar 14, 2022
@TomTirapani
Copy link
Member

So I took a look at this... doesn't look like using the updated hoist-dev-utils or unwinding the tree-shaking helps. This is definitely a bug on the FA side... they are using inconsistent casing for the imports / filenames themselves.

It took some digging (15k+ issues!), but I found this issue:
FortAwesome/Font-Awesome#18661

And this one, in which they say they'll fix for 6.1.0:
FortAwesome/Font-Awesome#18800

I think we just have to wait for them to fix in a patch release. Will keep an eye on it,

@TomTirapani
Copy link
Member

Tried again using the recently release v6.1.1, and the import issues around faThumbtack have been resolved.

I did a side-by-side comparison of the bundled icons against toolbox - almost all of them have changed, but the changes are subtle and shouldn't be too noticeable unless you're looking out for them. The following icons had the most pronounced changes, but even with these I think most apps should be fine to take the upgrade:

  • boxFull
  • eye
  • fileCsv
  • filePdf
  • folderOpen
  • gauge
  • impersonate
  • mobile
  • news
  • phone
  • pointerUp
  • shield
  • unlink

@lbwexler lbwexler closed this as completed Apr 5, 2022
@petradish
Copy link
Contributor

magic, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants