-
Notifications
You must be signed in to change notification settings - Fork 3
/
jibby_test.go
405 lines (374 loc) · 9.62 KB
/
jibby_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
// Copyright 2020 by David A. Golden. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"); you may
// not use this file except in compliance with the License. You may obtain
// a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
package jibby
import (
"bufio"
"bytes"
"encoding/hex"
"io"
"io/ioutil"
"path/filepath"
"strings"
"testing"
)
const JSONTestSuite = "testdata/JSONTestSuite/test_parsing"
const JibbyTestSuite = "testdata/jibbytests"
// TestJSONTestSuite_Passing tests the seriot.ch corpus for
// cases that must pass.
func TestJSONTestSuite_Passing(t *testing.T) {
t.Helper()
t.Parallel()
files := getTestFiles(t, JSONTestSuite, "y", ".json")
for _, f := range files {
path := filepath.Join(JSONTestSuite, f)
t.Run(f, func(t *testing.T) {
t.Parallel()
testPassingConversion(t, path, nil)
})
}
}
// TestJibbyTestSuite_Passing tests a local corpus in the
// same format as the seriot.ch corpus that must pass.
func TestJibbyTestSuite_Passing(t *testing.T) {
t.Helper()
t.Parallel()
files := getTestFiles(t, JibbyTestSuite, "y", ".json")
for _, f := range files {
path := filepath.Join(JibbyTestSuite, f)
t.Run(f, func(t *testing.T) {
t.Parallel()
testPassingConversion(t, path, nil)
})
}
}
// For implementation defined behavior: these errors are allowed as we don't
// support the related features.
var allowedErrors = []string{
ErrUnsupportedBOM.Error(),
"value out of range", // large ints/floats
}
// We assume valid UTF-8; these files test handling invalid strings,
// so we skip these files.
var unsupportedTests = map[string]bool{
"i_string_UTF-8_invalid_sequence.json": true,
"i_string_UTF8_surrogate_U+D800.json": true,
"i_string_invalid_utf-8.json": true,
"i_string_iso_latin_1.json": true,
"i_string_lone_utf8_continuation_byte.json": true,
"i_string_not_in_unicode_range.json": true,
"i_string_overlong_sequence_2_bytes.json": true,
"i_string_overlong_sequence_6_bytes.json": true,
"i_string_overlong_sequence_6_bytes_null.json": true,
"i_string_truncated-utf-8.json": true,
"i_string_utf16BE_no_BOM.json": true,
"i_string_utf16LE_no_BOM.json": true,
}
// TestJSONTestSuite_Passing tests the seriot.ch corpus for cases that are
// implementation defined. Variables above define exclusions.
func TestJSONTestSuite_ImplDefined(t *testing.T) {
t.Helper()
t.Parallel()
files := getTestFiles(t, JSONTestSuite, "i", ".json")
for _, f := range files {
if unsupportedTests[f] {
continue
}
path := filepath.Join(JSONTestSuite, f)
t.Run(f, func(t *testing.T) {
t.Parallel()
testPassingConversion(t, path, allowedErrors)
})
}
}
// GODRIVER-1947: The MongoDB Go driver doesn't properly handle surrogate pairs
// yet, so we allow different results for these.
var godriver1947 = map[string]bool{
"y_string_unicode_U+1FFFE_nonchar.json": true,
"y_string_unicode_U+10FFFE_nonchar.json": true,
"y_string_surrogates_U+1D11E_MUSICAL_SYMBOL_G_CLEF.json": true,
"y_string_last_surrogates_1_and_2.json": true,
"y_string_accepted_surrogate_pair.json": true,
"y_string_accepted_surrogate_pairs.json": true,
"i_string_inverted_surrogates_U+1D11E.json": true,
"i_string_incomplete_surrogates_escape_valid.json": true,
}
func testPassingConversion(t *testing.T, f string, allowedErrStrings []string) {
t.Helper()
text, err := ioutil.ReadFile(f)
if err != nil {
t.Fatalf("error reading %s: %v", f, err)
}
text = objectify(text)
jibbyGot, err := convertWithJibby(text)
if err != nil {
for _, v := range allowedErrStrings {
if strings.Contains(err.Error(), v) {
return
}
}
t.Fatalf("jibby error: %v\ntext: %s", err, string(text))
}
driverGot, err := convertWithGoDriver(text)
if err != nil {
// If Go driver can't parse, we can't compare against it.
t.Logf("skipping, mongo go driver error: %v\ntext: %s", err, string(text))
return
}
if !bytes.Equal(jibbyGot, driverGot) {
baseName := filepath.Base(f)
if godriver1947[baseName] {
return
}
t.Fatalf("jibby doesn't match Go driver:\njibby: %v\nDriver: %v", hex.EncodeToString(jibbyGot), hex.EncodeToString(driverGot))
}
}
// TestJSONTestSuite_Failing tests the seriot.ch corpus for
// cases that must error.
func TestJSONTestSuite_Failing(t *testing.T) {
t.Parallel()
files := getTestFiles(t, JSONTestSuite, "n", ".json")
for _, f := range files {
path := filepath.Join(JSONTestSuite, f)
t.Run(f, func(t *testing.T) {
t.Parallel()
testFailingConversion(t, path)
})
}
}
// TestJibbyTestSuite_Passing tests a local corpus in the
// same format as the seriot.ch corpus that must error.
func TestJibbyTestSuite_Failing(t *testing.T) {
t.Parallel()
files := getTestFiles(t, JibbyTestSuite, "n", ".json")
for _, f := range files {
path := filepath.Join(JibbyTestSuite, f)
t.Run(f, func(t *testing.T) {
t.Parallel()
testFailingConversion(t, path)
})
}
}
func testFailingConversion(t *testing.T, f string) {
t.Helper()
var err error
var jibbyGot []byte
text, err := ioutil.ReadFile(f)
if err != nil {
t.Fatalf("error reading %s: %v", f, err)
}
jsonReader := bufio.NewReader(bytes.NewReader(text))
jib, err := NewDecoder(jsonReader)
for err == nil {
jibbyGot, err = jib.Decode(make([]byte, 0, 256))
}
if err == nil {
t.Fatalf("expected error but got none for '%s' ('%s')", string(text), hex.EncodeToString(jibbyGot))
}
}
// TestStreaming has tests for document streams, including different formats,
// empty lists, error cases, etc.
func TestStreaming(t *testing.T) {
t.Parallel()
type testCase struct {
label string
input string
count int
errStr string
}
cases := []testCase{
// Document streams
{
label: "no docs",
input: "",
count: 0,
errStr: io.EOF.Error(),
},
{
label: "1 doc",
input: "{}",
count: 1,
errStr: io.EOF.Error(),
},
{
label: "1 doc, leading WS",
input: " {}",
count: 1,
errStr: io.EOF.Error(),
},
{
label: "2 docs, no WS",
input: "{}{}",
count: 2,
errStr: io.EOF.Error(),
},
{
label: "2 docs, space separated",
input: "{} {}",
count: 2,
errStr: io.EOF.Error(),
},
{
label: "2 docs, LF separated",
input: "{}\n{}",
count: 2,
errStr: io.EOF.Error(),
},
{
label: "2 docs, CRLF separated",
input: "{}\r\n{}",
count: 2,
errStr: io.EOF.Error(),
},
{
label: "3 docs, LF separated",
input: "{}\n{}\n{}",
count: 3,
errStr: io.EOF.Error(),
},
// Array of documents
{
label: "array: no docs",
input: "[]",
count: 0,
errStr: io.EOF.Error(),
},
{
label: "array: one doc w/ WS",
input: "[ {} ]",
count: 1,
errStr: io.EOF.Error(),
},
{
label: "array: 2 docs, no WS",
input: "[{},{}]",
count: 2,
errStr: io.EOF.Error(),
},
{
label: "array: 2 docs, space separated",
input: "[{}, {}]",
count: 2,
errStr: io.EOF.Error(),
},
{
label: "array: 2 docs, LF separated",
input: "[{},\n{}]",
count: 2,
errStr: io.EOF.Error(),
},
{
label: "array: 2 docs, CRLF separated",
input: "[{},\r\n{}]",
count: 2,
errStr: io.EOF.Error(),
},
{
label: "array: 3 docs",
input: "[{},{},{}]",
count: 3,
errStr: io.EOF.Error(),
},
{
label: "array: 2 arrays",
input: "[{},{},{}]\n[{}]",
count: 3,
errStr: io.EOF.Error(),
},
{
label: "array: no comma",
input: "[{} {}]",
count: 0,
errStr: "expecting value-separator or end of array",
},
{
label: "array: not terminated",
input: "[{},{}",
count: 1,
errStr: "unexpected EOF",
},
// Non documents in stream
{
label: "non-document",
input: `42`,
count: 0,
errStr: "Decode only supports object decoding",
},
{
label: "non-document after document",
input: `{} 42`,
count: 1,
errStr: "Decode only supports object decoding",
},
{
label: "non-document in array",
input: `[42]`,
count: 0,
errStr: "Decode only supports object decoding",
},
{
label: "start with array terminator",
input: `]{"a":"b"}`,
count: 0,
errStr: "Decode only supports object decoding",
},
}
for _, c := range cases {
c := c
t.Run(c.label, func(t *testing.T) {
t.Parallel()
var err error
jsonReader := bufio.NewReader(bytes.NewReader([]byte(c.input)))
jib, err := NewDecoder(jsonReader)
if err != nil && err != io.EOF {
t.Fatalf("unexpected error: %v", err)
}
buf := make([]byte, 0, 256)
var n int
for err == nil {
buf = buf[0:0]
buf, err = jib.Decode(buf)
if err != nil {
break
}
n++
}
if n != c.count {
t.Errorf("expected %d docs, but got %d", c.count, n)
}
if !strings.Contains(err.Error(), c.errStr) {
t.Errorf("expected error with '%s', but got %v", c.errStr, err)
}
})
}
}
// TestDepthLimit checks the ability to set a depth limit.
func TestDepthLimit(t *testing.T) {
t.Parallel()
testDepthLimit(t, `{"1":{"2":{"3":[{"5":"a"}]}}}`)
testDepthLimit(t, `{"1":{"2":{"3":[["5","a"]]}}}`)
}
func testDepthLimit(t *testing.T, input string) {
t.Helper()
out := make([]byte, 0)
jib, err := NewDecoder(bufio.NewReader(bytes.NewReader([]byte(input))))
if err != nil {
t.Fatal(err)
}
jib.MaxDepth(4)
out, err = jib.Decode(out)
if err == nil {
t.Fatalf("expected error and got nil")
}
jib, err = NewDecoder(bufio.NewReader(bytes.NewReader([]byte(input))))
if err != nil {
t.Fatal(err)
}
jib.MaxDepth(5)
_, err = jib.Decode(out)
if err != nil {
t.Fatalf("expected no error and got: %v", err)
}
}