Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance regression in previous_version function #366

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix performance regression in previous_version function #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/state/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ STABLE;
CREATE OR REPLACE FUNCTION %[1]s.previous_version(schemaname NAME) RETURNS text
AS $$
WITH RECURSIVE ancestors AS (
SELECT name, parent, migration_type, 0 AS depth FROM %[1]s.migrations
WHERE name = %[1]s.latest_version(schemaname)
SELECT name, schema, parent, migration_type, 0 AS depth FROM %[1]s.migrations
WHERE name = %[1]s.latest_version(schemaname) AND schema = schemaname
UNION ALL
SELECT m.name, m.parent, m.migration_type, a.depth + 1
SELECT m.name, m.schema, m.parent, m.migration_type, a.depth + 1
FROM %[1]s.migrations m
JOIN ancestors a ON m.name = a.parent
JOIN ancestors a ON m.name = a.parent AND m.schema = a.schema
)
SELECT a.name FROM ancestors a
JOIN information_schema.schemata s
Expand Down